? Pending

User tests: Successful: Unsuccessful:

avatar drmenzelit
drmenzelit
24 Feb 2021

Pull Request for Issue #32507 .

Summary of Changes

Added white-space:normal to site-description div.

Testing Instructions

See issue

Actual result BEFORE applying this Pull Request

Long tagline doesn't break on small devices.

Expected result AFTER applying this Pull Request

Long tagline breaks in more lines.

avatar drmenzelit drmenzelit - open - 24 Feb 2021
avatar drmenzelit drmenzelit - change - 24 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2021
Category Front End Templates (site) NPM Change
avatar himanshu007-creator himanshu007-creator - test_item - 24 Feb 2021 - Tested unsuccessfully
avatar himanshu007-creator
himanshu007-creator - comment - 24 Feb 2021

I have tested this item ? unsuccessfully on da71c41

I have tested this patch. I followed the instructions given in issue #32507 .To be sure of my test, i tested in debugger mode as well as in my mobile. But the patch didn't work. Correct me if i am wrong, but as-of-now, the patch doesn't seem effective.
MOBILE VIEW- Refer here
IN LAPTOP- Refer here


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32509.

avatar ChristineWk ChristineWk - test_item - 24 Feb 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 24 Feb 2021

I have tested this item successfully on da71c41

With Prebuilt Package


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32509.

avatar ChristineWk
ChristineWk - comment - 24 Feb 2021
avatar himanshu007-creator
himanshu007-creator - comment - 24 Feb 2021

screen shot 2021-02-24 at 17 22 30

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32509.

but why the patch is not working in my environment? can you suggest possible reasons and the solution?

avatar ChristineWk
ChristineWk - comment - 24 Feb 2021

@himanshu007-creator

This Patch doesn't work via Patchtester. It needs NPM. I used the Prebuilt Package instead.
See under Github: Check All Details


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32509.

avatar alikon
alikon - comment - 24 Feb 2021

probably you have only applyed the pr
you need to run npm build:css or whatever is the right command syntax

try installing the Prebuilt Package

avatar himanshu007-creator
himanshu007-creator - comment - 24 Feb 2021

probably you have only applyed the pr
you need to run npm build:css or whatever is the right command syntax

try installing the Prebuilt Package

will do it right now. ??

avatar infograf768 infograf768 - test_item - 24 Feb 2021 - Tested successfully
avatar infograf768
infograf768 - comment - 24 Feb 2021

I have tested this item successfully on da71c41


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32509.

avatar infograf768 infograf768 - change - 24 Feb 2021
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 24 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32509.

avatar ChristineWk
ChristineWk - comment - 24 Feb 2021
avatar himanshu007-creator himanshu007-creator - test_item - 24 Feb 2021 - Tested successfully
avatar himanshu007-creator
himanshu007-creator - comment - 24 Feb 2021

I have tested this item successfully on da71c41

white-space: normal works as described .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32509.

avatar infograf768 infograf768 - change - 24 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-24 17:31:25
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 24 Feb 2021
avatar infograf768 infograf768 - merge - 24 Feb 2021
avatar infograf768
infograf768 - comment - 24 Feb 2021

Tks

avatar infograf768
infograf768 - comment - 24 Feb 2021

:)

avatar himanshu007-creator
himanshu007-creator - comment - 24 Feb 2021

probably you have only applyed the pr
you need to run npm build:css or whatever is the right command syntax

try installing the Prebuilt Package

I am new here and ten to proceed exactly as given in testing instructions. It will take a while to get used to. But Thanks a lot for helping me out. It was so obvious, i should have looked out for that?

avatar drmenzelit
drmenzelit - comment - 25 Feb 2021

@himanshu007-creator it was my fault, my test instructions were not complete, I forgot to write that npm run build:css is needed. Sorry for that.

avatar himanshu007-creator
himanshu007-creator - comment - 25 Feb 2021

@himanshu007-creator it was my fault, my test instructions were not complete, I forgot to write that npm run build:css is needed. Sorry for that.

No problem mam?

Add a Comment

Login with GitHub to post a comment