[#32505] - Fix en-GB.com_associations.ini
- Fixed in Code Base
- 24 Feb 2021
- Medium
- Build: staging
- # 32505
- Diff
- dryabov:patch-5
User tests: Successful: Unsuccessful:
Fix argnum syntax (%1s means a string of minimal length of 1 character instead of first argument string %1$s)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
Looking now
It does work OK as is with Persian and obviously with this patch.
Better correct though.
EDIT: the reason we never had any problem is that it does not consider the figure, i.e. %1s or %2s are both considered as %s
As we are not in a phrase, but as forced order for 2 words (one is a bit more complex in Persian) separated by a > the figure maybe useless in this specific case.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32505.
| Status | Pending | ⇒ | Ready to Commit |
Setting RTC as this is an obvious patch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32505.
@infograf768 I did spot at least one other instance while investigating
I did spot at least one other instance while investigating
I found none more in core. Can you ellaborate?
Sorry it was a new string in J4
That one would need to be patched indeed.
richard67
- | Labels |
Added:
?
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-24 10:31:37 |
| Closed_By | ⇒ | HLeithner | |
| Labels | |||
Thanks
@infograf768 This PR does look correct but its been this way for 4+ years since the first commit