? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
23 Feb 2021

Pull Request for Issue # .

Summary of Changes

Structured data are important but I sugggest removing the itemprop="url" from the readmore links.
These are only internal links. In the newsflash module they are even wrong, as the articles there have no itemtype declaration.
If Readmore is used in 3rd party extensions, we never can know if structured data are used.

Testing Instructions

Inspection of the sourcecode.

Actual result BEFORE applying this Pull Request

readmore links have a itemprop="url" attribute

Expected result AFTER applying this Pull Request

readmore links have no itemprop="url" attribute

Documentation Changes Required

avatar chmst chmst - open - 23 Feb 2021
avatar chmst chmst - change - 23 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2021
Category Layout
avatar ChristineWk
ChristineWk - comment - 23 Feb 2021

Before:
<a class="btn btn-secondary" href="/example.org/index.php/4-about-your-home-page" itemprop="url" aria-label="Read more: About your home page">

After:
<a class="btn btn-secondary" href="/example.org/index.php/4-about-your-home-page" aria-label="Read more: About your home page">

avatar ChristineWk ChristineWk - test_item - 23 Feb 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 23 Feb 2021

I have tested this item successfully on 16bde27


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32501.

avatar dgrammatiko
dgrammatiko - comment - 23 Feb 2021

How about merging #25117 that introduces the JSON way and stop making the markup even harder than what already is in the project?

avatar drmenzelit
drmenzelit - comment - 24 Feb 2021

@dgrammatiko it seems we can't count with #25117 in 4.0
#25117 (comment)

avatar ceford ceford - test_item - 24 Feb 2021 - Tested successfully
avatar ceford
ceford - comment - 24 Feb 2021

I have tested this item successfully on 16bde27

I confirm the itemprop="url" attribute disappears from the Read more links I looked at.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32501.

avatar bembelimen bembelimen - change - 26 Feb 2021
Title
Remove itemprop="url" from readmore
[4.0] Remove itemprop="url" from readmore
avatar bembelimen bembelimen - edited - 26 Feb 2021
avatar richard67 richard67 - change - 28 Feb 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 28 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32501.

avatar infograf768 infograf768 - change - 28 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-28 15:02:09
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 28 Feb 2021
avatar infograf768 infograf768 - merge - 28 Feb 2021
avatar infograf768
infograf768 - comment - 28 Feb 2021

tks

Add a Comment

Login with GitHub to post a comment