[#32491] - [4.0] Individual class for tags as additional class
- Fixed in Code Base
- 24 Feb 2021
- Medium
- Build: 4.0-dev
- # 32491
- Diff
- drmenzelit:4.0-dev-tags-class
User tests: Successful: Unsuccessful:
Pull Request for Issue #31025 .
Summary of Changes
Changed the tag layout to use the tag class as additional class to the existent ones (btn btn-info btn-sm).
Testing Instructions
-Create or edit a tag
-Set a CSS Class for tag link in the Options of the tag, for example btn-danger
-Set a Tag in an article
-Look at the tag in the article
Actual result BEFORE applying this Pull Request
The tag has no styling and looks as a normal link.
Expected result AFTER applying this Pull Request
The tag is styled like the others, the additional class btn-danger override btn-info and the background is now red.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32491.
confirm @ceford :-)
Before:
After:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32491.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32491.
I have tested this item
Added btn-success class and it doesn't work.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32491.
Tried also now with: btn-success:
Do you mean the color?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32491.
@ceford, @ChristineWk , @SharkyKZ please test again, I replaced the btn-info with the tag class, so that btn-succes, btn-danger, etc. can be used.
| Labels |
Added:
?
|
||
Quy
- | Status | Ready to Commit | ⇒ | Pending |
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32491.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32491.
I have tested this item
This patch works fine.
BEFORE
AFTER
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32491.
| Status | Pending | ⇒ | Ready to Commit |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-24 04:38:40 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 16ef34c
Without the patch there is some styling (color red for danger for example) but the overall style is incorrect - button wrong height. With the patch it is fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32491.