J4 Issue ?
avatar drmenzelit
drmenzelit
21 Feb 2021

The new field layout utility classes from PR #32422 don't work when inside the form-grid (which defines display:grid) a control-group div is present.

Steps to reproduce the issue

Edit the templateDetails.xml file from Cassiopeia and add e.g. class="form-select span-1-inline stack" to the fields. Go to Template Styles and check the layout of the fields.

Expected result

The fields should display horizontal like described in the PR.

Actual result

The fields are still one below the other. The classes are there but the grid definition doesn't work here:
"grid-column has no effect on this element because it is not a grid element.
Try adding display:grid or display:inline-grid to the parent element. "

grafik

@ciar4n can you have a look here? Thanks

avatar drmenzelit drmenzelit - open - 21 Feb 2021
avatar joomla-cms-bot joomla-cms-bot - change - 21 Feb 2021
Labels Added: J4 Issue ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Feb 2021
avatar ciar4n
ciar4n - comment - 21 Feb 2021

It looks likes I shouldn't have reverted removing the extra attribute (#32422 (comment)). Because the class attribute does not add the class to the containing div, it is not suitable for these utilities.

I'll create a PR to fix. Originally I call the attribute display=" ... ".. I assume this name is ok?

avatar dgrammatiko
dgrammatiko - comment - 21 Feb 2021

Originally I call the attribute display

@ciar4n will parentclass be more appropriate/specific?

avatar ciar4n ciar4n - change - 21 Feb 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-02-21 23:23:32
Closed_By ciar4n
avatar ciar4n ciar4n - close - 21 Feb 2021
avatar ciar4n
ciar4n - comment - 21 Feb 2021

PR created and updated to use parentclass.... #32488

Add a Comment

Login with GitHub to post a comment