? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
21 Feb 2021

Pull Request for Issue # .

Summary of Changes

This simple PR does two things:

  • Remove duplicate category access check
  • Use setDocumentTitle to set page title to avoid repeating code

Testing Instructions

  • Create a menu item to link to Category Blog menu option
  • Apply patch
  • Access to that menu item, see that the page is still being displayed.
avatar joomdonation joomdonation - open - 21 Feb 2021
avatar joomdonation joomdonation - change - 21 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Feb 2021
Category Libraries
avatar chmst
chmst - comment - 21 Feb 2021

Is this a duplicate of #32484?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32483.

avatar joomdonation
joomdonation - comment - 21 Feb 2021

@chmst No, it is not. We have two separate classes, one is CategoriesView view (uses to display categories) and one for CategoryView (uses to display items from certain category).

avatar ChristineWk ChristineWk - test_item - 21 Feb 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 21 Feb 2021

I have tested this item successfully on de83e53


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32483.

avatar himanshu007-creator himanshu007-creator - test_item - 21 Feb 2021 - Tested successfully
avatar himanshu007-creator
himanshu007-creator - comment - 21 Feb 2021

I have tested this item successfully on de83e53

Menu item linking to the "CATEGORY BLOG" menu type is still being displayed.??


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32483.

avatar Quy Quy - change - 21 Feb 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 21 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32483.

avatar chmst chmst - change - 21 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-21 17:57:56
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 21 Feb 2021
avatar chmst chmst - merge - 21 Feb 2021
avatar chmst
chmst - comment - 21 Feb 2021

Thanks

Add a Comment

Login with GitHub to post a comment