Feeling Lucky
NPM Resource Changed
?
?
[#32480] - [4.0] Cassiopeia remove mixin a11y-visually-hidden
- Fixed in Code Base
- 23 Feb 2021
- Medium
- Build: 4.0-dev
- # 32480
- Diff
- brianteeman:editor
User tests: Successful: Unsuccessful:
This PR removes a mixin that as far as I can tell just duplicated the core bootstrap mixin but was using an older, now oout of date, version.
To test
- make a copy of templates\cassiopeia\css\template.css
- apply pr
- regenerate the css (node build/build.js --compile-css)
- compare the copy and the new template.css
The only difference should be for .container-header .mod-finder > label which is not using the correct code.
There should be no other differences.
(I really dont understand why we have so many bootstrap overrides that dont do anything)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
?
|
||
himanshu007-creator
- comment
- 22 Feb 2021
The only difference was in the specified component only.Refer here.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32480.
himanshu007-creator
- comment
- 22 Feb 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32480.
infograf768
- comment
- 22 Feb 2021
Please solve conflicts
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 22 Feb 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32480.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-23 11:47:53 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
chmst
- comment
- 23 Feb 2021
Thanks
brianteeman
- comment
- 23 Feb 2021
thank you
I have tested this item✅ successfully on 327d67c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32480.