[#32477] - [4.0] Update Date.php
- Fixed in Code Base
- 15 Mar 2021
- Medium
- Build: 4.0-dev
- # 32477
- Diff
- himanshu007-creator:himanshu007-creator-patch-1
User tests: Successful: 2 RohanModi06, srishty-07 Unsuccessful: 0
Pull Request for Issue #32286 .
Summary of Changes
Earlier , Error showed up code>DateTime::setTimezone(): Argument #1 ($timezone) must be of type DateTimeZone, null given in both cases.
But after these changes, new file is successfully
Testing Instructions
- Go to
System > Site Templates - Select
Cassiopeia Details and Files - Press
New Filefrom the toolbar - From the left side select the
html/mod_menufolder - Set
File Nameto exactly this:index-20210203-135009 - Set
File Typeto.php - Press
Create
Actual result BEFORE applying this Pull Request
Error shows up DateTime::setTimezone(): Argument #1 ($timezone) must be of type DateTimeZone, null given
Expected result AFTER applying this Pull Request
File created
Documentation Changes Required
I guess NO.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Please review and fix the code style errors https://ci.joomla.org/joomla/joomla-cms/40234/1/6
| Labels |
Added:
?
|
||
@HimAnshu007 thank you! A developer of course must test his own code, but there is a rule: A pr must be tested successfully by two other testers to be valid.
I followed the testing instructions and without applying the patch the file got created:
File created.
Editing file "/html/mod_menu/index-20210203-135009.php" in template "cassiopeia".
Did I miss something? I have just installed a new clone of the joomla-cms repo.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32477.
I followed the testing instructions and without applying the patch the file got created:
File created. Editing file "/html/mod_menu/index-20210203-135009.php" in template "cassiopeia".Did I miss something? I have just installed a new clone of the joomla-cms repo.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32477.
Hi @ceford , if you try this in PHP-8 you will get the following result.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32477.
bembelimen
- | Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32477.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32477.
Thank you
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-15 15:00:09 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 5304ee6
patch works fine and it is able to solve the issue. New file gets created without displaying any error.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32477.