NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
19 Feb 2021

Updates the RTL override for the skipto plugin to prevent a bug where 3000em were added to the left of the template.

Hopefully this will be fixed upstream eventually and this can be removed then

@ceford I think you observed this bug before

avatar brianteeman brianteeman - open - 19 Feb 2021
avatar brianteeman brianteeman - change - 19 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2021
Category Administration Templates (admin) NPM Change Front End Templates (site)
e3ff5a9 19 Feb 2021 avatar brianteeman cs
avatar brianteeman brianteeman - change - 19 Feb 2021
Labels Added: NPM Resource Changed ?
avatar ceford ceford - test_item - 20 Feb 2021 - Tested successfully
avatar ceford
ceford - comment - 20 Feb 2021

I have tested this item successfully on e3ff5a9

My Test: make Iranian the default site language. Reload the Home page and press the tab key to invoke the Skip to menu. Without the patch there is a huge space to the left and the page autoscrolls left on skipto menu hover. With the patch it works normally.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32463.

avatar infograf768
infograf768 - comment - 22 Feb 2021

I can't reproduce the issue on Firefox here.
On which browsers/OS should this be tested?

avatar infograf768
infograf768 - comment - 22 Feb 2021

Ah. I think I found out: here it happens after displaying the dropdown and NOT using it, i.e. click on the page.
testing now.

avatar infograf768 infograf768 - test_item - 22 Feb 2021 - Tested successfully
avatar infograf768
infograf768 - comment - 22 Feb 2021

I have tested this item successfully on e3ff5a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32463.

avatar infograf768 infograf768 - change - 22 Feb 2021
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 22 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32463.

avatar infograf768 infograf768 - close - 23 Feb 2021
avatar infograf768 infograf768 - merge - 23 Feb 2021
avatar infograf768 infograf768 - change - 23 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-23 06:39:23
Closed_By infograf768
Labels Added: ?
avatar infograf768
infograf768 - comment - 23 Feb 2021

Tks

avatar brianteeman
brianteeman - comment - 23 Feb 2021

thanks

Add a Comment

Login with GitHub to post a comment