? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
18 Feb 2021

Pull Request for Issue #32407 and #32406.

Summary of Changes

This PR fixes 2 issues as described in #32407 and #32406 :

  • Tag created by Save as Copy should be unpublished
  • When Save as Copy, if Admin changes Title of the tag before saving, Alias of the created tag should be created base on the new title

Testing Instructions

  • Test #1:
  1. Click on a tag to edit
  2. Press Save as Copy button in the toolbar
  3. Before patch: Tag is published. After patch, tag is unpublished
  • Test #2:
  1. Click on a tag to edit
  2. Change title of the Tag, press Save as Copy button in the toolbar.
  3. Before patch: Alias is not generated base on the new Title. After patch, alias is generated base on Title.
avatar joomdonation joomdonation - open - 18 Feb 2021
avatar joomdonation joomdonation - change - 18 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Feb 2021
Category com_tags Administration
avatar joomdonation joomdonation - change - 18 Feb 2021
Labels Added: ?
avatar Quy Quy - test_item - 22 Feb 2021 - Tested successfully
avatar Quy
Quy - comment - 22 Feb 2021

I have tested this item successfully on add0ee8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32454.

avatar Quy
Quy - comment - 22 Feb 2021

For test 2 after step 2, do Press Save as Copy button in the toolbar.

avatar joomdonation joomdonation - change - 22 Feb 2021
The description was changed
avatar joomdonation joomdonation - edited - 22 Feb 2021
avatar infograf768 infograf768 - test_item - 23 Feb 2021 - Tested successfully
avatar infograf768
infograf768 - comment - 23 Feb 2021

I have tested this item successfully on add0ee8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32454.

avatar infograf768 infograf768 - change - 23 Feb 2021
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 23 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32454.

avatar HLeithner HLeithner - change - 23 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-23 18:28:31
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 23 Feb 2021
avatar HLeithner HLeithner - merge - 23 Feb 2021
avatar HLeithner
HLeithner - comment - 23 Feb 2021

Thanks, even if I don't like the unpublishing on save2copy but it's reflect the behavior of most of the other components.

avatar infograf768
infograf768 - comment - 23 Feb 2021

I like the unpublished. It lets user check/modify before publishing. ?

Add a Comment

Login with GitHub to post a comment