Code style still bad, using spaces for indentation, see here https://ci.joomla.org/joomla/joomla-cms/40181/1/6 .

Another thing is that 4.0 is already in Beta phase so we have a feature freeze, and this here is a new feature.

So this PR should be made for the 4.1-dev branch.

I see the Intro image in the results list but in one instance followed by an error panel starting:

( ! ) Notice: Undefined variable: extraAttr in /Users/ceford/Sites/joomla-cms-4/components/com_finder/tmpl/search/default_result.php on line 96

Just to be 100% clear. The decision was not to remove all descriptions. The decision was to display descriptions on screen instead of as a popup and only to include descriptions that it was felt were essential.

@brianteeman Thanks for clarifying and explaining it more precise than I did. It's exactly like you say.

Now the problem remains that if this is a new feature then it should go into 4.1.

@zero-24 What's your opinion?

Just to be 100% clear. The decision was not to remove all descriptions. The decision was to display descriptions on screen instead of as a popup and only to include descriptions that it was felt were essential.

Thanks for clarifying @brianteeman.
Then the addition of a description in a "vague" field name abides with the taken decision. Right?
Of course the answer is subjective to how someone perceives something as vague. But this by no means can be taken as inconsistency.

Now the problem remains that if this is a new feature then it should go into 4.1.

@zero-24 What's your opinion?

That question should be directed at @bembelimen but i personally would agree to move this to 4.1

Everyting what is a nice idea and improvement, but does not fix a bug should be 4.1. as we did for example with my pr #32223

@sakiss thanks for your code! I originally wrote about this idea #27815, but it was closed.

Sometimes we need to use full article image instead of intro article image. I think this pr should check for full article image also if intro images does not exist.

I have tested this item ✅ successfully on 50afef0

I have tested this item ✅ successfully on 50afef0

I've rebased this PR to 4.1-dev and adjusted the title accordingly.

As this PR has 2 good tests and the rebase was clean without any conflicts, this PR can be set to RTC.

RTC

Could you please merge that?

Could you please merge that?

Me not because I have set RTC. It's on the release lead @bembelimen to decide.

@sakiss could you reduce the complexity or explain why you need setter and getter and an object?

I would suggest to remove them and simple add 2 parameter imageUrl and imageAlt.

I agree with @HLeithner, it enough just

$result->image = 'fobar/blabla.jpg'
$result->imageAlt = 'bla';

this already handled by setElement()

and do not require set/get Image.

When rendering you just do:

if ($this->result->image)
{
   //... render image
}

Thanks @sakiss for this PR. I really like it but @HLeithner and @Fedik have a point there. If you add this and probably also do a bit styling for the output (float?) it's good to go.

please also remove properties, it already handled by __get/__set methods,
see my previous comment

@bembelimen Unfortunately i am not aware of BS5 and the classes that J4 uses in general. I would appreciate it, if someone more knowledgable on that, have a look. Btw. The image uses the "Image Class" property/setting, which was introduced for the joomla content as well (not sure if this is still valid) and is supposed to provide the styling to the image.

You mean to get/set the image properties using the __get/__set functions?

Correct, please read the comment for the method:

Then we will have consistency. This allows us to add any extra value to the result object, without introducing extra properties and getters/setters, for each.

@sakiss You've closed this by purpose or by accident?

@richard67 on purpose for obvious reasons