Feeling Lucky
?
[#3245] - Module Articles Newsflash (mod_articles_news) shows articles "Ordering" only in DESC [#33429]
- Closed
- 6 Mar 2014
- Medium
- Build: staging
- # 3245
- Diff
- pe7er:staging
- Foreign ID 33429
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
wilsonge
- comment
- 6 Mar 2014
Agreed its the same as Thomas' PR. Why has that not yet been merged though - it's been ready to review for aggeees. And it's more minor than half the bug fixes we put in.
pe7er
- comment
- 6 Mar 2014
Yes, it is indeed a patch for the same issue as your patch.
Actually, I prefer your solution!
- It's shorter
- It uses JGlobal language strings, which makes additions in the module's language file unnecessary.
- It adds "Hits" as extra option, which can be useful.
Bakual
- comment
- 6 Mar 2014
Agreed its the same as Thomas' PR. Why has that not yet been merged though - it's been ready to review for aggeees. And it's more minor than half the bug fixes we put in.
Basically, my error was to do it as a feature request and not as a bug 
I'm closing this one as duplicate then.
Thanks anyway Peter!
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-03-06 12:47:29 |
I think it's the same as this (old) one from me
#1057