? ? Pending

User tests: Successful: Unsuccessful:

avatar AndySDH
AndySDH
17 Feb 2021

Summary of Changes

Currently in Joomla, the Title of the article is rendered as a H2 instead of a H1.

I get that H1 can also be the "Page Heading" aka Menu Title.

But in an article view, you're most likely not gonna wanna have the Menu Title as an H1.

I personally don't care as I fix it in template overrides anyway. But as a standard, common practice, my two cents is that Article title should be H1 by default.

Actual result BEFORE applying this Pull Request

Article title is H2.

Expected result AFTER applying this Pull Request

Article title is H1 if Menu Title is hidden.

Votes

# of Users Experiencing Issue
1/2
Average Importance Score
3.00

avatar AndySDH AndySDH - open - 17 Feb 2021
avatar AndySDH AndySDH - change - 17 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Feb 2021
Category Front End com_content
avatar infograf768 infograf768 - change - 17 Feb 2021
Title
Shouldn't Article Title be H1?
[4.0] Shouldn't Article Title be H1?
avatar infograf768 infograf768 - edited - 17 Feb 2021
avatar Razzo1987 Razzo1987 - test_item - 17 Feb 2021 - Tested successfully
avatar Razzo1987
Razzo1987 - comment - 17 Feb 2021

I have tested this item successfully on bf485b9

The title of the article became H1 when it is a menù item.

it correctly is H2 on category pare or home


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32448.

avatar ceford ceford - test_item - 18 Feb 2021 - Tested successfully
avatar ceford
ceford - comment - 18 Feb 2021

I have tested this item successfully on bf485b9

Seems like a good idea and consistent with Page Title hidden by default.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32448.

avatar brianteeman
brianteeman - comment - 18 Feb 2021

I would prefer it if you tested to see if the page title is displayed and only then decide if article title should be h1 or h2

avatar AndySDH AndySDH - change - 18 Feb 2021
Labels Added: ?
avatar AndySDH
AndySDH - comment - 18 Feb 2021

I would prefer it if you tested to see if the page title is displayed and only then decide if article title should be h1 or h2

Actually good idea. Done, please test again!

avatar AndySDH AndySDH - change - 18 Feb 2021
The description was changed
avatar AndySDH AndySDH - edited - 18 Feb 2021
avatar richard67
richard67 - comment - 18 Feb 2021

See also #11772 and #30209 for history and reference.

avatar AndySDH
AndySDH - comment - 18 Feb 2021

See also #11772 and #30209 for history and reference.

Thanks, consensus seemed to be for this to go in J4 instead of J3, so here we go :)

avatar particthistle particthistle - test_item - 20 Feb 2021 - Tested successfully
avatar particthistle
particthistle - comment - 20 Feb 2021

I have tested this item successfully on cff4a0c

Tested with the new scenario:

  • H1 for article title when Page Heading hidden.
  • H2 for article title, H1 for Page Heading when Page Heading set to show.

Nice adjustment @AndySDH - It's also something I've had to override in the past.

Tested during onboarding session with GSoC 2021 students.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32448.

avatar himanshu007-creator himanshu007-creator - test_item - 20 Feb 2021 - Tested successfully
avatar himanshu007-creator
himanshu007-creator - comment - 20 Feb 2021

I have tested this item successfully on cff4a0c

It ran successfully.
This was my first test during the session for potential GSOC students.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32448.

avatar AndySDH
AndySDH - comment - 20 Feb 2021

Thanks guys! Asking for RTC after 2+ successful tests.

avatar richard67 richard67 - change - 20 Feb 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 20 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32448.

avatar richard67
richard67 - comment - 20 Feb 2021

@wilsonge @bembelimen It's ok for this to go into 4.0? Or is there some reason to move it to 4.1? For me 4.0 is ok.

avatar simbus82
simbus82 - comment - 21 Feb 2021

@wilsonge @bembelimen It's ok for this to go into 4.0? Or is there some reason to move it to 4.1? For me 4.0 is ok.

A not correct "heading" is a problem with SEO. So if we want a good SEO in Joomla 4.0, this is a solved bug ?

avatar laoneo
laoneo - comment - 22 Feb 2021

If this one gets accepted, then there are more places to adjust, basically every menu item needs this change.

avatar brianteeman
brianteeman - comment - 22 Feb 2021

Good point @laoneo if changed then this should be applied everywhere

avatar AndySDH
AndySDH - comment - 22 Feb 2021

If someone else wanna do that, great.. For now I think we can merge the article which is definitely the most important view.

avatar laoneo
laoneo - comment - 22 Feb 2021

Sure. This one here goes as example. If accepted we should do followup pr's.

avatar AndySDH AndySDH - change - 24 Feb 2021
Labels Added: ?
avatar AndySDH
AndySDH - comment - 24 Feb 2021

@bembelimen Done :)

No more tests needed, right?

avatar ReLater
ReLater - comment - 24 Feb 2021

Really? Again this stupid solution that will affect any older Joomla installations where people started with H3 in their articles because the title is H2? There isn't any valid argument for this H1 philosophy. H1 has nothing todo with SEO nowadays.

Use an override if you want this behavior! and don't kick established users again in the ass with this nonsense. They have to rewrite their articles because of bad interpretation of SEO rules/recommendations. Pure legends.

avatar AndySDH
AndySDH - comment - 24 Feb 2021

Really? Again this stupid solution that will affect any older Joomla installations where people started with H3 in their articles because the title is H2? There isn't any valid argument for this H1 philosophy. H1 has nothing todo with SEO nowadays.

Use an override if you want this behavior! and don't kick established users again in the ass with this nonsense. They have to rewrite their articles because of bad interpretation of SEO rules/recommendations. Pure legends.

Really? If you started with Heading 3 because Heading 2 was the title, well, you always adopted a bad practice.

You might wanna read:
https://yoast.com/how-to-use-headings-on-your-site/
https://www.reliablesoft.net/h1-tag

In Joomla 4 everything will be changed, it's a new major version so you should expect breaking changes. Including this. Otherwise we will never be able to fix old mistakes if we have to support old mistakes.

It's very easy for you to replace your headings if you need it, with an extension such as DB Replacer.

avatar simbus82
simbus82 - comment - 24 Feb 2021

Really? Again this stupid solution that will affect any older Joomla installations where people started with H3 in their articles because the title is H2? There isn't any valid argument for this H1 philosophy. H1 has nothing todo with SEO nowadays.

Use an override if you want this behavior! and don't kick established users again in the ass with this nonsense. They have to rewrite their articles because of bad interpretation of SEO rules/recommendations. Pure legends.

It's not the first time that you say lot of BS and bad informations about SEO. Lot of people here talk only about things they know.
So, please, don't touch topics that you not know. If you are a great dev, continue to develop, and stop talking about SEO.

We are trying to erase all great errors of the past, like module title with H3, articles with same content in Meta Title and H1 (ops, wrong... H2?), logos with H1, meta keywords fields... Etc etc...

avatar chmst
chmst - comment - 24 Feb 2021

I don't mind SEO, I am interested in accessibility. Correct Heading structure starts with H1. There can be many H1 on a site, but a site must have at least one H1.
So for me this is a nice improvement and if @laoneo makes this consistently in all views it is an improvement for a11y.

avatar chmst
chmst - comment - 24 Feb 2021

@bembelimen which milstone?

avatar ReLater
ReLater - comment - 25 Feb 2021

I don't mind SEO, I am interested in accessibility. Correct Heading structure starts with H1. There can be many H1 on a site, but a site must have at least one H1

My point is exactly the same. Correct and consistent structure! Pages/Users that had a H2 for article will now s_tart with a H1 followed by a H3_ in any f'ing article on their sites. Immediately after updating Joomla to 4.

And it's absolutely no must that the structure has to start with a H1. That's a legend nowadays.

Not anybody is setting the H1 via page_heading setting!!

Therefore it's less work for people that absolutely want this feature to use an override than, again, to kick all the people outside in the ass that have already well structured pages for years and have to change their sites now. It's just a new B\C break without real reasons. Without benefits.

avatar bembelimen
bembelimen - comment - 25 Feb 2021

@ReLater is correct here, on a SEO-wise view there is absolutely no necessity to have a h1 tag on the page, already communicated by Google approx 1,5 year ago.

But what is more important is the comment from @chmst :

I don't mind SEO, I am interested in accessibility. Correct Heading structure starts with H1. There can be many H1 on a site, but a site must have at least one H1.

The headline structure plays an important role with making a web page accessible. It's very important for screen readers to have a proper structure. I understand the point @ReLater is making but I think we should not stick with the (in my opinion) wrong approach just for the sake of "we did it in the past, too".

The argument:

Use an override if you want this behavior!

could be used the other way around.

So it should definitely be in Joomla! 4.0. But now here I become a bit greedy: would it be possible @AndySDH to implement this for each core extension within this PR? Otherwise we run into the risk to be inconsistent again, having in articles the proper solution but not in all the other core components.

One personal word to @simbus82

It's not the first time that you say lot of BS and bad informations about SEO. Lot of people here talk only about things they know.
So, please, don't touch topics that you not know. If you are a great dev, continue to develop, and stop talking about SEO.

Would you please stop your personal attacks how stupid and ignorant all the other people beside you are? We can discuss here on a grown up level. As I know @ReLater (and all the other contributors) he is very passionated for Joomla! and really has a point here (+ is correct in his statement), so please respect different opinions, whenever you agree or disagree. That's not the first time you were not respectful towards different opinions. Thanks.

avatar AndySDH
AndySDH - comment - 25 Feb 2021

would it be possible @AndySDH to implement this for each core extension?

@bembelimen Maybe. If this PR gets merged first. If this gets merged, then I could potentially look into the others in another PR.
I'm not gonna do all that work without knowing for sure that it will be merged (and knowing it will just turn into another discussion like now and nothing will be done)

So like @laoneo said:

This one here goes as example. If accepted we should do followup pr's.

avatar bembelimen
bembelimen - comment - 25 Feb 2021

OK, here is the deal, I like the improvement and I would merge it as a whole solution for all core components.
As I said, I don't want in the core with only one component changed. So if you would do the other changes, too with the same quality. I would merge it (after 2 tests).

avatar AndySDH
AndySDH - comment - 25 Feb 2021

OK, here is the deal, I like the improvement and I would merge it as a whole solution for all core components.
As I said, I don't want in the core with only one component changed. So if you would do the other changes, too with the same quality. I would merge it (after 2 tests).

Merge this one and I'll do the others asap, promise.

avatar laoneo laoneo - close - 25 Feb 2021
avatar laoneo laoneo - merge - 25 Feb 2021
avatar laoneo laoneo - change - 25 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-25 17:55:37
Closed_By laoneo
avatar laoneo
laoneo - comment - 25 Feb 2021

Ok, lets go forward here. Thanks for all the input. @AndySDH waiting for your followup pr's :-)

avatar AndySDH
AndySDH - comment - 25 Feb 2021

Thanks @laoneo! Will do.

avatar AndySDH
AndySDH - comment - 26 Feb 2021

Made PR for all other views #32525, please test it!

avatar AndySDH AndySDH - change - 10 Mar 2021
The description was changed
avatar AndySDH AndySDH - edited - 10 Mar 2021

Add a Comment

Login with GitHub to post a comment