? NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar drmenzelit
drmenzelit
17 Feb 2021

Pull Request for Issue #32443 .

Summary of Changes

Added xxl as breakpoint in the variables of Cassiopeia.
Changed the max-width of grid-child to xxl
Increased the width of main content column.

Testing Instructions

Run npm
Check the website in displays > 1400px

Actual result BEFORE applying this Pull Request

No xxl breakpoint in Cassiopeia (inspect the template.css file)

Expected result AFTER applying this Pull Request

xxl breakpoint available in Cassiopeia
In displays > 1400px you will notice, that the whole width of the content has increased a bit.

Documentation Changes Required

avatar drmenzelit drmenzelit - open - 17 Feb 2021
avatar drmenzelit drmenzelit - change - 17 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Feb 2021
Category Front End Templates (site) NPM Change
avatar Magnytu2
Magnytu2 - comment - 17 Feb 2021

Hello, I do not see the difference in front. I expected to recover a width of 1320px for a screen display of 1400px minimum.

avatar drmenzelit drmenzelit - change - 17 Feb 2021
Labels Added: ? NPM Resource Changed ?
avatar drmenzelit drmenzelit - change - 17 Feb 2021
The description was changed
avatar drmenzelit drmenzelit - edited - 17 Feb 2021
avatar drmenzelit
drmenzelit - comment - 17 Feb 2021

My bad.. please check again. I have added more information in the description above.

avatar Magnytu2
Magnytu2 - comment - 17 Feb 2021

Oh AWESOME it works a big thank you. All I have to do now is find a solution to display badges in the modules and menus titles. And the same goes for the icons in front of the module and menu titles.

avatar richard67
richard67 - comment - 17 Feb 2021

@Magnytu2 If you have tested this PR with success, then please go to it in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/32446 and use the "Test this" button. Then select the appropriate test result and submit. Thanks in advance.

P.S.: You should know that procedure meanwhile ;-)

avatar Magnytu2
Magnytu2 - comment - 17 Feb 2021

I don't know if that relates to the last modification ...

I set a menu link in blog view of a category with the code "Blog Class" in "image-left". I don't know if it's wanted, but I don't think so. The images are of different sizes. However, the three images are 600px wide.

Screenshot_2021-02-17 BD, Humour

avatar drmenzelit
drmenzelit - comment - 17 Feb 2021

Do you had the problem with the size of the images without the modifications of this PR?

avatar Magnytu2
Magnytu2 - comment - 17 Feb 2021

last night the images were the same size. But I can't go back to validate it.

avatar Magnytu2
Magnytu2 - comment - 17 Feb 2021

I just found an answer. If you only have one line of intro text or two, the image size changes.

avatar Magnytu2
Magnytu2 - comment - 17 Feb 2021

I confirm, sorry this must be normal, the size of the image varies depending on the length of the intro text. I will validate this PR. thank you very much

avatar Magnytu2 Magnytu2 - test_item - 17 Feb 2021 - Tested successfully
avatar Magnytu2
Magnytu2 - comment - 17 Feb 2021

I have tested this item successfully on d89e22e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32446.

avatar drmenzelit
drmenzelit - comment - 17 Feb 2021

I confirm, sorry this must be normal, the size of the image varies depending on the length of the intro text. I will validate this PR. thank you very much

We had the issue previously, but had solved it... do you have a link to your website?
You can inspect the image element in the browser, the blog has display flex and the column with the image should have a flexbasis of 40%

avatar Magnytu2
Magnytu2 - comment - 17 Feb 2021

You can follow the construction of my site at this address http://www.magnytudeweb.com/fnak.com/index.php

avatar drmenzelit
drmenzelit - comment - 17 Feb 2021

I don't see the problem:
grafik

avatar Magnytu2
Magnytu2 - comment - 17 Feb 2021

i have shortened the intro text now : http://www.magnytudeweb.com/fnak.com/index.php/bd-humour

avatar brianteeman
brianteeman - comment - 17 Feb 2021

why are we overriding the bootstrap defaults here?

avatar drmenzelit
drmenzelit - comment - 17 Feb 2021

The changes were introduced by @hans2103 changing px to em as basis unit

avatar brianteeman
brianteeman - comment - 17 Feb 2021

We really should not be overriding the bootstrap defaults unless there is a very good reason (and would have avoided this bug)

avatar ceford ceford - test_item - 18 Feb 2021 - Tested successfully
avatar ceford
ceford - comment - 18 Feb 2021

I have tested this item successfully on d89e22e

I see the content width change on a Mac with 1440 px wide screen. I note that the Bootstrap default breakpoints are in px so conversion to em seems to depend on default em size.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32446.

avatar brianteeman
brianteeman - comment - 18 Feb 2021

Conversion to em is wrong.

avatar ceford
ceford - comment - 18 Feb 2021

Conversion to em is wrong.

Are you saying my comment is wrong or that the use of em in the css is wrong? We seem to have a mix of rem and em in the diff!

avatar brianteeman
brianteeman - comment - 18 Feb 2021

we should not be changing the bootstrap default

avatar richard67 richard67 - change - 20 Feb 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 20 Feb 2021

Setting to RTC as it has 2 good tests. Overriding of bootstrap defaults can be removed later with another PR, eg #32467 can be updated after this here has been merged (or vice versa if the other one is faster)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32446.

avatar brianteeman
brianteeman - comment - 20 Feb 2021

It is still the wrong fix

avatar richard67
richard67 - comment - 20 Feb 2021

Yes, I see. When #32467 will be merged, there will be not much left of this PR.

avatar brianteeman
brianteeman - comment - 20 Feb 2021

I just added this to the other pr description

all the other cassiopeia overrides need to be checked as well to make sure they are not overriding things that it doesnt need to. This is just a start that I hope some people with more frontend skills can continue in another pr

avatar richard67 richard67 - change - 21 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-21 18:23:40
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 21 Feb 2021
avatar richard67 richard67 - merge - 21 Feb 2021
avatar richard67
richard67 - comment - 21 Feb 2021

Thanks!

Add a Comment

Login with GitHub to post a comment