User tests: Successful: Unsuccessful:
Pull Request for Issue #32443 .
Added xxl as breakpoint in the variables of Cassiopeia.
Changed the max-width of grid-child to xxl
Increased the width of main content column.
Run npm
Check the website in displays > 1400px
No xxl breakpoint in Cassiopeia (inspect the template.css file)
xxl breakpoint available in Cassiopeia
In displays > 1400px you will notice, that the whole width of the content has increased a bit.
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Templates (site) NPM Change |
Labels |
Added:
?
NPM Resource Changed
?
|
My bad.. please check again. I have added more information in the description above.
Oh AWESOME it works a big thank you. All I have to do now is find a solution to display badges in the modules and menus titles. And the same goes for the icons in front of the module and menu titles.
@Magnytu2 If you have tested this PR with success, then please go to it in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/32446 and use the "Test this" button. Then select the appropriate test result and submit. Thanks in advance.
P.S.: You should know that procedure meanwhile ;-)
Do you had the problem with the size of the images without the modifications of this PR?
last night the images were the same size. But I can't go back to validate it.
I just found an answer. If you only have one line of intro text or two, the image size changes.
I confirm, sorry this must be normal, the size of the image varies depending on the length of the intro text. I will validate this PR. thank you very much
I have tested this item
I confirm, sorry this must be normal, the size of the image varies depending on the length of the intro text. I will validate this PR. thank you very much
We had the issue previously, but had solved it... do you have a link to your website?
You can inspect the image element in the browser, the blog has display flex and the column with the image should have a flexbasis of 40%
You can follow the construction of my site at this address http://www.magnytudeweb.com/fnak.com/index.php
i have shortened the intro text now : http://www.magnytudeweb.com/fnak.com/index.php/bd-humour
why are we overriding the bootstrap defaults here?
We really should not be overriding the bootstrap defaults unless there is a very good reason (and would have avoided this bug)
I have tested this item
I see the content width change on a Mac with 1440 px wide screen. I note that the Bootstrap default breakpoints are in px so conversion to em seems to depend on default em size.
Conversion to em is wrong.
Conversion to em is wrong.
Are you saying my comment is wrong or that the use of em in the css is wrong? We seem to have a mix of rem and em in the diff!
we should not be changing the bootstrap default
Status | Pending | ⇒ | Ready to Commit |
Setting to RTC as it has 2 good tests. Overriding of bootstrap defaults can be removed later with another PR, eg #32467 can be updated after this here has been merged (or vice versa if the other one is faster)
It is still the wrong fix
@brianteeman How about the following changes from this PR here?
These seem to be valid for me also when #32467 will be merged, but I might be wrong.
I just added this to the other pr description
all the other cassiopeia overrides need to be checked as well to make sure they are not overriding things that it doesnt need to. This is just a start that I hope some people with more frontend skills can continue in another pr
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-21 18:23:40 |
Closed_By | ⇒ | richard67 | |
Labels |
Added:
?
|
Thanks!
Hello, I do not see the difference in front. I expected to recover a width of 1320px for a screen display of 1400px minimum.