NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
16 Feb 2021

Pull Request for Issue #32433.

Summary of Changes

Correct border-radius in subhead buttons (Artticle Edit)..

Testing Instructions

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

avatar ciar4n ciar4n - open - 16 Feb 2021
avatar ciar4n ciar4n - change - 16 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2021
Category Administration Templates (admin) NPM Change
avatar ChristineWk ChristineWk - test_item - 16 Feb 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 16 Feb 2021

I have tested this item successfully on 724aae1

With Prebuilt Package


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32440.

avatar ciar4n ciar4n - change - 16 Feb 2021
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2021
Category Administration Templates (admin) NPM Change Administration Templates (admin) NPM Change Layout
avatar richard67
richard67 - comment - 16 Feb 2021

@ChristineWk Could you fetch the patch again and redo your test? There has been made a change meanwhile. Thanks in advance.

avatar richard67 richard67 - test_item - 16 Feb 2021 - Tested successfully
avatar richard67
richard67 - comment - 16 Feb 2021

I have tested this item successfully on 1be17c5

Tested both LTR and RTL. Both ok.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32440.

avatar ChristineWk
ChristineWk - comment - 16 Feb 2021

@richard67 Sorry, at the moment the update (caused from previous pr) does not work. Will try again ...
screen shot 2021-02-16 at 22 05 08


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32440.
avatar richard67
richard67 - comment - 16 Feb 2021

@ChristineWk Oh, yes, I have forgotten you are using the prebuild packages. That means you would have to start again from the beginning, that would be a bit uncomfortable.

avatar Quy Quy - test_item - 16 Feb 2021 - Tested successfully
avatar Quy
Quy - comment - 16 Feb 2021

I have tested this item successfully on 1be17c5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32440.

avatar Quy Quy - change - 16 Feb 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 16 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32440.

avatar Quy
Quy - comment - 16 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32440.

avatar ChristineWk ChristineWk - test_item - 16 Feb 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 16 Feb 2021

I have tested this item successfully on 1be17c5

Ok, went back to Nightly dev xml and started again :-)
You already have the latest Joomla version, ‎4.0.0-beta8-dev+pr.32440.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32440.

avatar Quy Quy - change - 16 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-16 22:43:02
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 16 Feb 2021
avatar Quy Quy - merge - 16 Feb 2021
avatar Quy
Quy - comment - 16 Feb 2021

Thanks!

avatar ciar4n
ciar4n - comment - 16 Feb 2021

Thanks for the tests! ?

Add a Comment

Login with GitHub to post a comment