[#32423] - Remove nav class on links in contacts
- Fixed in Code Base
- 16 Feb 2021
- Medium
- Build: 4.0-dev
- # 32423
- Diff
- drmenzelit:4.0-dev-contact-links
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Removed class nav flex-column in the list of links in contacts. Added rel="noopener noreferrer" on links.
Other links lists in J4 are "normal" lists and not nav lists (blog_links.php in blog layout, default_links.php on articles). We should stay consistent.
Testing Instructions
Create a contact, add some links.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
chmst
- | Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32423.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32423.
Why a nofollow on these link?
Must not be decided by design. Good rel for external links are rel="noopener noreferrer", but we have to let the user decide if he wants to pass "link juice" to those links of his contacts.
Must not be decided by design.
That would mean a new parameter. Can be modified by override.
Must not be decided by design.
That would mean a new parameter. Can be modified by override.
Yes, a new parameter is a good solution.
However is wrong to put a "rel=nofollow" as default in the "core" for this type of links.
If I really wanted to use the Joomla contact extension, I would enter the "contacts" data, like website link, because I want my site to be related to it. Otherwise I just do not mention the website if I do not want the passage of "link juice".
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32423.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32423.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32423.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32423.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-16 11:07:21 |
| Closed_By | ⇒ | wilsonge |
Thanks!
please delete this spam and block the user
I have tested this item✅ successfully on fe9460c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32423.