? NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar drmenzelit
drmenzelit
14 Feb 2021

Pull Request for Issue #32417 .

Summary of Changes

Added BS5 classes to com_contact/default_articles.php

Testing Instructions

Create a contact page for an author and activate the display of articles in this contact.

Actual result BEFORE applying this Pull Request

The list of articles is not styled, see screenshot in issue #32417

Expected result AFTER applying this Pull Request

grafik

Documentation Changes Required

avatar drmenzelit drmenzelit - open - 14 Feb 2021
avatar drmenzelit drmenzelit - change - 14 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2021
Category Front End com_contact
avatar Magnytu2
Magnytu2 - comment - 14 Feb 2021

@drmenzelit Super it works very well. But since these are links to the articles, shouldn't that be underlined as a link? And maybe have the same line spacing as the links on the right in the connection panel?

Capture d’écran 2021-02-14 à 16 57 12

avatar chmst
chmst - comment - 14 Feb 2021

Yes, links must be underlined.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32420.

avatar drmenzelit drmenzelit - change - 14 Feb 2021
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2021
Category Front End com_contact Front End com_contact Templates (site) NPM Change
avatar drmenzelit drmenzelit - change - 14 Feb 2021
The description was changed
avatar drmenzelit drmenzelit - edited - 14 Feb 2021
avatar drmenzelit
drmenzelit - comment - 14 Feb 2021

Added underlines with the last commit

avatar drmenzelit drmenzelit - change - 14 Feb 2021
The description was changed
avatar drmenzelit drmenzelit - edited - 14 Feb 2021
avatar drmenzelit
drmenzelit - comment - 14 Feb 2021

New commit with list style instead of nav

avatar drmenzelit drmenzelit - change - 14 Feb 2021
Labels Added: NPM Resource Changed
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2021
Category Front End com_contact Templates (site) NPM Change Front End com_contact
avatar drmenzelit drmenzelit - change - 14 Feb 2021
Title
Add BS5 classes to articles in contact
Change style of articles list in contact
avatar drmenzelit drmenzelit - edited - 14 Feb 2021
avatar chmst
chmst - comment - 14 Feb 2021

@Magnytu2 could you re-test please?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32420.
avatar Magnytu2
Magnytu2 - comment - 14 Feb 2021

Yes it works very well. A big thank you to you ! http://magnytudeweb.com/fnak.com/index.php/auteurs/m-j-arlidge

Capture d’écran 2021-02-14 à 21 09 44

avatar chmst chmst - test_item - 15 Feb 2021 - Tested successfully
avatar chmst
chmst - comment - 15 Feb 2021

I have tested this item successfully on 9d64f87

on Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32420.

avatar infograf768 infograf768 - test_item - 15 Feb 2021 - Tested successfully
avatar infograf768
infograf768 - comment - 15 Feb 2021

I have tested this item successfully on 9d64f87


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32420.

avatar infograf768 infograf768 - change - 15 Feb 2021
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 15 Feb 2021

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32420.

avatar infograf768 infograf768 - change - 15 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-15 09:23:22
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 15 Feb 2021
avatar infograf768 infograf768 - merge - 15 Feb 2021
avatar infograf768
infograf768 - comment - 15 Feb 2021

tks

Add a Comment

Login with GitHub to post a comment