? ? Pending

User tests: Successful: Unsuccessful:

avatar drmenzelit
drmenzelit
14 Feb 2021

Pull Request for Issue # .

Summary of Changes

Added BS5 classes for margin and padding to article index (toc)
Added color to active link
Run npm (scss changes)

Testing Instructions

Create an article with page breaks and article index (table of content)

Actual result BEFORE applying this Pull Request

The article index has no margin to the article text, the links have no adding and the active link is not discernible:

Screenshot_2021-02-14 Article with index

Expected result AFTER applying this Pull Request

The article index has a margin (works in lrt too), the links have some padding and the active link is visually discernible:

grafik

Documentation Changes Required

avatar drmenzelit drmenzelit - open - 14 Feb 2021
avatar drmenzelit drmenzelit - change - 14 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2021
Category Front End Plugins
avatar drmenzelit drmenzelit - change - 14 Feb 2021
Labels Added: J4 Issue ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2021
Category Front End Plugins Front End Plugins Templates (site) NPM Change
avatar drmenzelit drmenzelit - change - 14 Feb 2021
The description was changed
avatar drmenzelit drmenzelit - edited - 14 Feb 2021
avatar drmenzelit drmenzelit - change - 14 Feb 2021
Title
Add margin to article index (toc)
Add styling to article index (toc)
avatar drmenzelit drmenzelit - edited - 14 Feb 2021
avatar richard67
richard67 - comment - 14 Feb 2021

@drmenzelit We don't use labels "... Issue" on PR's, only on issues.

avatar brianteeman brianteeman - test_item - 14 Feb 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Feb 2021

I have tested this item successfully on 4eec2fe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32415.

avatar chmst chmst - test_item - 14 Feb 2021 - Tested successfully
avatar chmst
chmst - comment - 14 Feb 2021

I have tested this item successfully on 4eec2fe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32415.

avatar chmst chmst - change - 14 Feb 2021
Status Pending Ready to Commit
avatar chmst
chmst - comment - 14 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32415.

avatar wilsonge wilsonge - change - 15 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-15 19:36:15
Closed_By wilsonge
Labels Added: ?
Removed: J4 Issue
avatar wilsonge wilsonge - close - 15 Feb 2021
avatar wilsonge wilsonge - merge - 15 Feb 2021
avatar wilsonge
wilsonge - comment - 15 Feb 2021

Thanks!

Add a Comment

Login with GitHub to post a comment