Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#32411] - [4.0]joomla.asset.json

? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
13 Feb 2021

First draft at documenting the contents of the joomla.assets.json file to make it more intuitive for users to understand.

@Fedik @wilsonge I hope I guessed these correctly - perhaps you can add the missing descriptions?

PARTIAL Pull Request for Issue #32408 - it does NOT close that discussion

avatar brianteeman brianteeman - open - 13 Feb 2021
avatar brianteeman brianteeman - change - 13 Feb 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Feb 2021
Category ⇒ Front End Templates (site)
avatar brianteeman brianteeman - change - 14 Feb 2021
Labels Added: ?
avatar wilsonge
wilsonge - comment - 14 Feb 2021

template.active.language as you can (kinda) see triggers the \Joomla\CMS\WebAsset\AssetItem\LangActiveAssetItem class which loads a CSS file for the language (should be obvious if you look at the class)

avatar Fedik
Fedik - comment - 14 Feb 2021

the link additionally to George comment:

joomla-cms/libraries/src/WebAsset/AssetItem/LangActiveAssetItem.php

Lines 16 to 23 in 421c3a1

/**
* Web Asset Item class for load asset file for active language.
* Used in core templates.
*
* @since 4.0.0
*/
class LangActiveAssetItem extends WebAssetItem
{

avatar brianteeman brianteeman - change - 14 Feb 2021
Title
…
[4.0] DRAFT joomla.asset.json
[4.0]joomla.asset.json
avatar brianteeman brianteeman - edited - 14 Feb 2021
avatar Fedik
Fedik - comment - 14 Feb 2021

Please copy it also to an administrator template. To be consistent.

19cad47 14 Feb 2021 avatar brianteeman lang
acff042 14 Feb 2021 avatar brianteeman atum
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2021
Category Front End Templates (site) ⇒ Administration Templates (admin) Front End Templates (site)
avatar ceford
ceford - comment - 14 Feb 2021

I have an interest in this topic. I have created a custom site template based on Cassiopeia but using Bootstrap 5 when Joomla was on BS4. I read the docs referred to and would have found the json descriptions helpful. Please carry on.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32411.

avatar dgrammatiko
dgrammatiko - comment - 14 Feb 2021

@ceford fwiw the js of BS5 is compatible with BS4 as long as you use the new data-bs-* convention. When I did the conversion I also used the BS4 css it was @wilsonge's PR that brought the BS5 css to Joomla. So what you're doing is fine and maybe should be some kind of unofficially supported template as BS4 still supports IE11, but that's not my call

avatar Fedik Fedik - test_item - 14 Feb 2021 - Tested successfully
avatar Fedik
Fedik - comment - 14 Feb 2021

I have tested this item ✅ successfully on acff042

code review

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32411.

avatar dgrammatiko dgrammatiko - test_item - 15 Feb 2021 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 15 Feb 2021

I have tested this item ✅ successfully on acff042

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32411.

avatar alikon alikon - change - 15 Feb 2021
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 15 Feb 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32411.

avatar wilsonge wilsonge - change - 15 Feb 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-02-15 19:21:36
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 15 Feb 2021
avatar wilsonge wilsonge - merge - 15 Feb 2021
avatar wilsonge
wilsonge - comment - 15 Feb 2021

Thanks!

avatar brianteeman
brianteeman - comment - 15 Feb 2021

thank you

Add a Comment

Login with GitHub to post a comment