[#32405] - [4.0] RTL: Correcting skipto separators alignment
- Fixed in Code Base
- 14 Feb 2021
- Medium
- Build: 4.0-dev
- # 32405
- Diff
- infograf768:4.0_skipto_rtl
User tests: Successful: Unsuccessful:
Pull Request for Issue #32395
Summary of Changes
Added rtl override in template-rtl.scss in both Atum and Cassiopea
Testing Instructions
Install Persian language.
Add to the admin persian language folder this file
plg_system_skipto.txt
Note: some strings are not translated (Aside, Header, Form)
(Change .txt to .ini)
Make sure skipto system plugin is set to be used on site (or both).
Load site with Persian as default language. Click on Tab and then Enter
Patch, run npm and test again
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change Front End Templates (site) |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32405.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32405.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32405.
I have not tested this item.
I see the skipto menu heading shift from left aligned to right aligned. But ...
I have a real big problem with the Cassiopeia template with rtl as default - there is a hug blank area to the left of the page and whenever I hover over the skipto menu the page autoscrolls left for miles. This in both Firefox and Chrome on Mac OSX.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32405.
I have a real big problem with the Cassiopeia template with rtl as default - there is a hug blank area to the left of the page and whenever I hover over the skipto menu the page autoscrolls left for miles. This in both Firefox and Chrome on Mac OSX.
@ceford You have this problem only with this PR applied? Or also without?
Please ignore my comment - I still had a wide pre line in an article left over from a previous test. My fault. I suppose the auto-scrolling the wrong way is still relevant.
Can happen. Thanks for reporting back.
@ceford are you sure you resolved it as I see it in atum now that you mentioned it
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32405.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32405.
I have tested this item
put my test back to successful as this is not the cause of the error I am seeing
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32405.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-14 00:07:00 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
This is fine in itself. Thanks!
Done.