No Code Attached Yet
avatar infograf768
infograf768
12 Feb 2021

Steps to reproduce the issue

Log in front end as author or editor
Create or edit an article
Try to insert a menu item through the cms xtd

Expected result

A list of menu items to choose from

Actual result

Empty list

Screen Shot 2021-02-12 at 08 14 51

avatar infograf768 infograf768 - open - 12 Feb 2021
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 12 Feb 2021
avatar infograf768 infograf768 - change - 12 Feb 2021
Labels Added: ?
avatar infograf768 infograf768 - labeled - 12 Feb 2021
avatar joomdonation
joomdonation - comment - 18 Feb 2021

The behavior is the same in Joomla 3. As of right now, we only show the menu items belong to menus which the current user has Access Administration Interface permission.

avatar infograf768
infograf768 - comment - 18 Feb 2021

@joomdonation
The problem is that the menu xtd is displayed when creating/editing when it should not.

avatar joomdonation
joomdonation - comment - 18 Feb 2021

Main question is when it should be displayed. We have different permission check in different place here:

Also, since the behavior is the same with Joomla 3, maybe this is not a Release Blocker.

avatar infograf768 infograf768 - change - 18 Feb 2021
Labels Removed: ?
avatar infograf768 infograf768 - unlabeled - 18 Feb 2021
avatar infograf768
infograf768 - comment - 18 Feb 2021

Took off the release blocker. But one has to agree we are not very consequent with permissions here.
As I see it, the permissions set for the xtd should be the ones that count here.
And the problem is that they are not in our case.
An Author/Editor by default has no core.create or core.edit permissions for com_menus. Therefore the button should not display at all.

avatar infograf768
infograf768 - comment - 18 Feb 2021

What I mean is that we may have something more serious behind these permissions not being applied.

avatar joomdonation
joomdonation - comment - 18 Feb 2021

An Author/Editor by default has no core.create or core.edit permissions for com_menus. Therefore the button should not display at all.

=> If the user does not have that permission, it won't be displayed. My Joomla 4 default setup shows that the Editor group has both permission set to Allowed, the Author group has core.create permission set to Allowed, that's the reason the button is being displayed there.

We just display the button here to allow selecting menu item, so checking for core.create or core.edit permission seems not right to me. Maybe we should check for core.manage (because without core.manage permission, we won't see any menu items displayed for selecting)

avatar infograf768
infograf768 - comment - 18 Feb 2021

If the user does not have that permission, it won't be displayed. My Joomla 4 default setup shows that the Editor group has both permission set to Allowed, the Author group has core.create permission set to Allowed, that's the reason the button is being displayed there.

Oops, you are definitely right...

avatar infograf768
infograf768 - comment - 18 Feb 2021

To add to the confusion, a manager using the menu xtd in backend when editing an article gets a 403...

avatar joomdonation
joomdonation - comment - 18 Feb 2021

Yes. Because in the backend, we check for core.manage permission. Look like check for core.manage before showing the button would be right choice.

avatar infograf768
infograf768 - comment - 18 Feb 2021

I wonder why we should forbid a manager from using the xtd menu when editing an article?
The manager has no access to the com_menus backend anyway.
Security?

avatar joomdonation
joomdonation - comment - 18 Feb 2021

I'm unsure. Maybe we want to prevent users without permission to see the menu items.

avatar infograf768 infograf768 - change - 28 Jun 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-06-28 07:44:48
Closed_By infograf768
Labels Added: No Code Attached Yet
Removed: ?
avatar infograf768 infograf768 - close - 28 Jun 2022

Add a Comment

Login with GitHub to post a comment