[#32390] - [4.0] View "New module" - some css
- Fixed in Code Base
- 12 Feb 2021
- Medium
- Build: 4.0-dev
- # 32390
- Diff
- chmst:new-module-hover
User tests: Successful: Unsuccessful:
Summary of Changes
Meanwhile we have removed shadows around cards at hover.
The button on the card is better integrated into the card.
Testing Instructions
See cards before applying the patch, especially on hover. Apply and run npm build:css and compare.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No whadow on hover, buttons match better in the card
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
| Title |
|
||||||
I am not sue about removing the card outline. Pretty much every edit form has a details tab with common options in the right panel. Whilst revising the Help screens I thought it would be an idea to demarcate these 'panels' with a legend. Having something is helpful! Having nothing just puts input boxes alongside input boxes with a different label layout - see Edit Contact for example.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32390.
I have tested this item
Forget may last comment - not really relevant to this PR - although I think the shadow is helpful.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32390.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32390.
| Labels |
Added:
?
?
NPM Resource Changed
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-12 15:56:53 |
| Closed_By | ⇒ | laoneo | |
| Labels | |||
Thanks!
I have tested this item✅ successfully on d37c007
Before applying the PR, the box for each module type has round corners at the top but not at the bottom because of the button.
The box shadow on hovering somehow visualizes in addition to the mouse pointer that the complete box and not only the button is clickable, but it has such a light colour that it is hard to see and makes the page look a bit "blurry".
After applying the PR, the box for each module type has the same round corners everywhere.
The "blurry" box shadow has been removed. Now when hovering there is (beside the mouse pointer) no visualization that the complete box is clickable, but for me that's ok. Maybe there will be feedback from others that it would be good to have a colour change for the complete box when hovering, or maybe not. We will see.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32390.