Feeling Lucky
?
?
[#32342] - [4.0] Validate URL for Iframe Wrapper menu item type
- Fixed in Code Base
- 12 Feb 2021
- Medium
- Build: 4.0-dev
- # 32342
- Diff
- joomdonation:validate_url
User tests: Successful: Unsuccessful:
Pull Request for Issue #32245 (part).
Summary of Changes
This small PR change field type of the url field type to url, also add validate="url" to make sure a valid URL needs to be saved before the menu item can be saved.
Testing Instructions
- Create a menu item of Iframe Wrapper menu item type
- Before patch: You can enter anything into URL
- After patch: Only valid URL is accepted
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_wrapper |
| Labels |
Added:
?
|
||
ceford
- comment
- 11 Feb 2021
I have tested this item
I give this a pass because it sets the field parameters in the form xml file to what I expect. Fixing the client and server side validation to only accept a valid url are separate issues.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32342.
toivo
- comment
- 11 Feb 2021
I have tested this item
Tested successfully in Beta8-dev of 9 February.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32342.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 12 Feb 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32342.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-12 16:07:49 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 12 Feb 2021
Thanks!
One can still enter just ------------------ and it gets changed to http://------------------ - is that all the url does?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32342.