[#32339] - [4.0] Validate Path to Temp and Log Folder
- Fixed in Code Base
- 24 Feb 2021
- Medium
- Build: 4.0-dev
- # 32339
- Diff
- joomdonation:validate_temp_and_log_path
User tests: Successful: Unsuccessful:
Pull Request for Issue #31920 and #31921
Summary of Changes
This PR adds some validation to Path to Temp Folder and Path to Log Folder to make sure it is valid and writable before saving to Global Configuration. In case the folder is not writable, a warning will be displayed and default folder will be used instead (same with how we handle Path to Cache Folder)
Testing Instructions
- Go to System -> Global Configuration
- Try to enter wrong path to Path to Temp Folder and Path to Log Folder
- Before path: These wrong paths are saved
- After patch: There are warning displayed and default paths are saved.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config Language & Strings |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32339.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32339.
I would not merge it as we really should avoid code which suppresses errors.
| Status | Ready to Commit | ⇒ | Pending |
I would not merge it as we really should avoid code which suppresses errors.
@laoneo Would it be ok if @joomdonation follows your recommendation above ? Or does it need more changes than that?
Sure
Sorry hit to early enter... Replacing the surpressing with proper condition checks should be fine. Not on a pc right now... But there are for sure better ways to do it.
| Labels |
Added:
?
|
||
I have tested this item
This patch worked as expected, raising warnings for wrong paths.REFER HERE
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32339.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-24 04:33:36 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
Removed: ? |
||
Thanks!
Merged it as the only things which has changed since the two successfull tests was that opendir was replaced by is_dir and is_writable.
I have tested this item✅ successfully on 6c36f00
Tested successfully in Beta8-dev of 8 February using PHP 8.0.1 in Wampserver 3.2.4.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32339.