Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
4 Mar 2014

Currently, we use the CSS class inputbox in 391 places in the backend, however it is only a single CSS rule dealing with it. And this one can be removed without any issues.

This PR removes the class from the backend, but leaves frontend (and libraries) untouched.

The one CSS rule which deals with that class is found in Hathor and targets the login page. For LTR languages, there is no change at all when we remove the rule. For RTL languages it even looks better :smile:

There are two goals with this PR. First it removes unused and inconsistent output and second it will make it easier to deal with "chosen" as we can use a default class for select elements.

I targeted this PR against 3.3 because there is a theoretical chance of breaking 3rd party administrator templates if they exists and work with this class.

avatar Bakual Bakual - open - 4 Mar 2014
avatar betweenbrain
betweenbrain - comment - 4 Mar 2014

As reported on the tracker, looks good :+1: Thanks @Bakual

avatar Bakual Bakual - reference | a031cd4 - 25 Mar 14
avatar Bakual Bakual - close - 25 Mar 2014
avatar Bakual
Bakual - comment - 25 Mar 2014

Merged

avatar Bakual Bakual - change - 25 Mar 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-03-25 19:27:17
avatar Bakual Bakual - close - 25 Mar 2014
avatar Bakual Bakual - head_ref_deleted - 25 Mar 2014
avatar Bakual Bakual - reference | 19dbce8 - 26 Mar 14
avatar Bakual Bakual - reference | 57ee7ad - 12 May 14

Add a Comment

Login with GitHub to post a comment