[#32317] - [4.0] Use setDocumentTitle to set document title for com_content
- Fixed in Code Base
- 6 Feb 2021
- Medium
- Build: 4.0-dev
- # 32317
- Diff
- joomdonation:com_content_set_document_title
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Same with other similar PRs, this PR modifies com_content code to use setDocumentTitle method from HtmlView class to set document title instead of using the same repeating code on all views.
Testing Instructions
Create menu items to link to link to the follow menu item types of com_content:
- Archived Articles
- Category Blog
- Categories List
- Create Article
- Featured Articles
- Single Articles
Then access to these menu items, make sure browser page title is the same before and after patch.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32317.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32317.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-06 12:29:54 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
@joomdonation @wilsonge See https://github.com/joomla/joomla-cms/blob/4.0-dev/components/com_content/src/View/Category/HtmlView.php lines 176-178, 178 should be deleted
$this->setDocumentTitle($title);
$this->document->setTitle($title);
And article view still has a call of $this->document->setTitle() for multiple-pages
I have tested this item✅ successfully on 107d428
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32317.