Joomla! Issue Tracker | Joomla! CMS #32310 - [4.0] Clean up Tags view

? ?

Fixed in Code Base
8 Feb 2021
Medium
Build: 4.0-dev
# 32310
Diff
joomdonation:clean_up_view_tags

Pending

User tests: Successful: Unsuccessful:

joomdonation
5 Feb 2021

Pull Request for Issue # .

Summary of Changes

This PR makes several clean up to view tags of com_tags component:

Remove the code to check access level and unset tag item. It is not needed because that is processed model already (only tags with right access level returned)
Remove code to calculate $title from $this->item. item is not a property of the class, it always null, so these code will never run (seems this code is copied from somewhere)
Use setDocumentTitle method from HtmlView class to set page title instead of calculating the page title manually

Testing Instructions

Create a menu item to link to List All Tags menu item type of Tags component
Access to that menu item. Check (the displayed tags, browser page title), confirm that it is displayed the same before and after patch

b64d3a9 5 Feb 2021

Clean up Tags view

joomdonation - open - 5 Feb 2021

joomdonation - change - 5 Feb 2021

Status

New

⇒

Pending

joomla-cms-bot - change - 5 Feb 2021

Category

⇒

com_tags Front End

394398a 5 Feb 2021

Remove un-used comments. It is not needed anymore

joomdonation - change - 5 Feb 2021

Labels

Added: ?

ChristineWk - test_item - 5 Feb 2021 - Tested successfully

ChristineWk - comment - 5 Feb 2021

I have tested this item ✅ successfully on 394398a

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32310.}

richardfrederik67 - test_item - 5 Feb 2021 - Tested successfully

richard67 - alter_testresult - 5 Feb 2021 - richardfrederik67: Not tested

chmst - test_item - 6 Feb 2021 - Tested successfully

chmst - comment - 6 Feb 2021

I have tested this item ✅ successfully on 394398a

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32310.}

alikon - change - 6 Feb 2021

Status

Pending

⇒

Ready to Commit

alikon - comment - 6 Feb 2021

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32310.}

richard67 - test_item - 6 Feb 2021 - Tested successfully

richard67 - comment - 6 Feb 2021

I have tested this item ✅ successfully on 394398a

One more test than necessary is never bad ;-)

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32310.}

infograf768 - change - 8 Feb 2021

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2021-02-08 08:21:07
Closed_By		⇒	infograf768
Labels	Added: ?

infograf768 - close - 8 Feb 2021

infograf768 - merge - 8 Feb 2021

infograf768 - comment - 8 Feb 2021

tks

Add a Comment

Login with GitHub to post a comment

Older
Newer