? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
3 Feb 2021

Summary of Changes

This PR removes icon/class in modal footer to be consistent with other modals.

This PR does not fix the hover color/order in #29560.

Testing Instructions

Go to Home Dashboard.
Scroll to the bottom.
Click Add module to the dashboard.

Actual result BEFORE applying this Pull Request

Icon in button.

Expected result AFTER applying this Pull Request

No icon in button.

avatar Quy Quy - open - 3 Feb 2021
avatar Quy Quy - change - 3 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Feb 2021
Category Administration com_cpanel
avatar ChristineWk ChristineWk - test_item - 3 Feb 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 3 Feb 2021

I have tested this item successfully on 9bc2609


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32293.

avatar toivo toivo - test_item - 4 Feb 2021 - Tested successfully
avatar toivo
toivo - comment - 4 Feb 2021

I have tested this item successfully on 9bc2609

Tested successfully in Beta8-dev of 4 February using PHP 8.0.1.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32293.

avatar richard67 richard67 - change - 4 Feb 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 4 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32293.

avatar richard67 richard67 - change - 4 Feb 2021
Labels Added: ? ?
avatar wilsonge wilsonge - change - 4 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-04 14:00:09
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - close - 4 Feb 2021
avatar wilsonge wilsonge - merge - 4 Feb 2021
avatar wilsonge
wilsonge - comment - 4 Feb 2021

Thanks!

Add a Comment

Login with GitHub to post a comment