As far as I can tell this code is never used as the breadcrumb seperator is set by css
joomla-cms/modules/mod_breadcrumbs/src/Helper/BreadcrumbsHelper.php
Lines 77 to 86 in 06b1c3b
Labels |
Added:
?
|
@richard67 thats J3 ;)
Ah yours is for J4 I just see. Need more coffee.
In J4 it is indeed not used anywhere in the core. But maybe it's intended to be used by 3rd party stuff?
It was but I dont see how it really can be used now. The module used to have an option to select what you wanted to use for the seperator and it was used for that. As there is no option anymore and this is a module specific helper I cant see how any 3rd party stuff could use it. If they wanted to offer seperator options etc then it would have to be in a complete module and not a simple override
Should... by which rule? Never heard, yet I use a lot of different CMS.
It's inside a module, so i need to many setting for adapt it assigning different "styles" per page. Like in Joomla 3: so it's a step back.
Can you explain me what accessibility has to do with choosing the breadcrumbs separator, please?
It was a recommentation from a blind a11y expert, not a rule, because screen readers use to read also the separators, if they are not hidden by an aria attribute, I think CSS is good practice.
But I don't know why this option has been removed.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-04 13:37:01 |
Closed_By | ⇒ | brianteeman |
closing as once again a perfectly sensible issue has been taken completely off track
Maybe https://github.com/joomla/joomla-cms/blob/staging/modules/mod_breadcrumbs/mod_breadcrumbs.php#L20 ?