?
avatar brianteeman
brianteeman
3 Feb 2021

As far as I can tell this code is never used as the breadcrumb seperator is set by css

/**
* Set the breadcrumbs separator for the breadcrumbs display.
*
* @param string $custom Custom xhtml compliant string to separate the items of the breadcrumbs
*
* @return string Separator string
*
* @since 1.5
*/
public static function setSeparator($custom = null)

avatar brianteeman brianteeman - open - 3 Feb 2021
avatar joomla-cms-bot joomla-cms-bot - change - 3 Feb 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 3 Feb 2021
avatar brianteeman
brianteeman - comment - 3 Feb 2021

@richard67 thats J3 ;)

avatar richard67
richard67 - comment - 3 Feb 2021

Ah yours is for J4 I just see. Need more coffee.

avatar richard67
richard67 - comment - 3 Feb 2021

In J4 it is indeed not used anywhere in the core. But maybe it's intended to be used by 3rd party stuff?

avatar brianteeman
brianteeman - comment - 3 Feb 2021

It was but I dont see how it really can be used now. The module used to have an option to select what you wanted to use for the seperator and it was used for that. As there is no option anymore and this is a module specific helper I cant see how any 3rd party stuff could use it. If they wanted to offer seperator options etc then it would have to be in a complete module and not a simple override

avatar simbus82
simbus82 - comment - 3 Feb 2021

So, now we can't change the breadcrumb separator in J4.
image

For me it's a bug.

avatar chmst
chmst - comment - 3 Feb 2021

@simbus82 Separators should be set via css., also for accessibility

avatar simbus82
simbus82 - comment - 3 Feb 2021

Should... by which rule? Never heard, yet I use a lot of different CMS.
It's inside a module, so i need to many setting for adapt it assigning different "styles" per page. Like in Joomla 3: so it's a step back.

Can you explain me what accessibility has to do with choosing the breadcrumbs separator, please?

avatar chmst
chmst - comment - 3 Feb 2021

It was a recommentation from a blind a11y expert, not a rule, because screen readers use to read also the separators, if they are not hidden by an aria attribute, I think CSS is good practice.

But I don't know why this option has been removed.

avatar infograf768
infograf768 - comment - 4 Feb 2021

@chmst
See #32297 for RTL breadcrumbs and more.

avatar brianteeman brianteeman - change - 4 Feb 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-02-04 13:37:01
Closed_By brianteeman
avatar brianteeman brianteeman - close - 4 Feb 2021
avatar brianteeman
brianteeman - comment - 4 Feb 2021

closing as once again a perfectly sensible issue has been taken completely off track

Add a Comment

Login with GitHub to post a comment