[#32280] - [4.0] Fix wrong link to category on user action log
- Fixed in Code Base
- 10 Feb 2021
- Medium
- Build: 4.0-dev
- # 32280
- Diff
- joomdonation:patch-5
User tests: Successful: Unsuccessful:
Pull Request for Issue #32264 .
Summary of Changes
Instead of getting $option directly from request (which is wrong in case category is created from add article/add contact... screen), we can just get $option (component) from type_alias(com_content.article, com_categories.category....) of the content type.
This solve error in case the content type is created using a different component (like category is created from com_contact or com_content) as shown in the issue #32264
Testing Instructions
- Follow instructions at #32264 to see the issue
- Apply patch, confirm the issue fixed
Actual result BEFORE applying this Pull Request
The link to category is wrong
Expected result AFTER applying this Pull Request
The link to category is right
Documentation Changes Required
If this change is accepted, similar change should be done to other methods in the plugin like onContentAfterDelete, onContentChangeState....
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
richard67
- | Title |
|
||||||
humm...
after pr i've been redirected here
http://localhost/bs5/administrator/index.php?option=com_categories&view=category&layout=edit&id=13&extension=com_content
it should be &extension=com_contact or whatever
p.s
we have the same issue on j3
| Labels |
Added:
?
|
||
| Category | Front End Plugins | ⇒ | Administration com_categories Front End Plugins |
Thanks @alikon . The extension in the edit link is default to com_content (get from extension variable in the request) instead of the extension of that category for some reasons
I modified code of category controller and the link is correct now. However, I'm unsure if that's the right way :(.
I'm unsure if that's the right way :(.
me neither, but at least, now it works
let's request some review
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32280.
@alikon I made small modification to the code to only get extension from category itself in case no extension is passed in the request (like the link from action log http://localhost/joomla4/administrator/index.php?option=com_categories&task=category.edit&id=22 ). It should be OK now. But we will wait for review from @wilsonge .
I have tested this item
I ran into trouble with this. After applying the patch I needed to delete the contact, the category and the log and go through the creation test again. Then it worked.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32280.
richardfrederik67
-
old log item will have wrong url
that's ok
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32280.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32280.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-10 08:44:47 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
Tks.
I have tested this item✅ successfully on 3212df3
Tested successfully in Beta8-dev of 3 February using PHP 8.0.1.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32280.