Feeling Lucky
?
[#32274] - [4.0] Load the namespace map in execute
- Fixed in Code Base
- 8 Feb 2021
- Medium
- Build: 4.0-dev
- # 32274
- Diff
- Digital-Peak:j4/cli/nsmap
User tests: Successful: Unsuccessful:
Pull Request for pr #31886.
Summary of Changes
Load the namespace app in execute as the file write operation needs an application object to check if FTP should be used.
Testing Instructions
- Copy the discover app from here https://github.com/Digital-Peak/DPDocker/blob/php/versions/webserver/scripts/discoverapp.php to the joomla root.
- Remove the lines 25 to 37 in the file discoverapp.php of your joomal root
- Link an extension with a symlink
- Delete the file /administrator/cache/autoload_psr4.php
- Execute
php discoverapp.phpin your Joomla root folder
Actual result BEFORE applying this Pull Request
"Failed to start application" error.
Expected result AFTER applying this Pull Request
Extensions are discovered.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
laoneo
- comment
- 8 Feb 2021
You are completely right. Now we are inline with the other apps.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-08 12:57:33 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 8 Feb 2021
Thanks!
Looks fine. But I just realised we should reuse the same trait the other applications are using (
\Joomla\CMS\Application\ExtensionNamespaceMapper) so can you quickly refactor to that at the same time please?