I have tested this item ✅ successfully on 32f0efe

Why the double underline: class="mod-articlesnews__item" ? Should the article class be an Option parameter?

@ceford the double underline in css classes is following the BEM methodology: http://getbem.com/naming/

Which article class do you mean?

Why the double underline: class="mod-articlesnews__item" ?

This would be typical of BEM class naming which was adopted in #20147

Should the article class be an Option parameter?

The current Module Class would cover all requirements for applying style to these items

Thanks for the info on BEM. I learned something today!

Should the article class be an Option parameter?

What I meant was: should class="mod-articlesnews__item" be hard-coded to this name or should it be a parameter filled out by the user in the Articles - Newsflash Advanced tab. No need to answer - it was a passing thought.

@ciar4n Why only for the default layout (sorry if silly question)?

@richard67 The other layouts put each item as a list item which makes them manageable. It was only the default layout that had all content flat in a single div.

@richard67 The other layouts put each item as a list item which makes them manageable. It was only the default layout that had all content flat in a single div.

I see. Yes, I can confirm they are all lists. Thanks for feedback.

I have tested this item ✅ successfully on 32f0efe

Beside code review I've tested the default layout also in a real test and can confirm it looks the same with and without the PR.

RTC

Thanks

Thank you