? ?
avatar PhilETaylor
PhilETaylor
2 Feb 2021

Steps to reproduce the issue

Edit an article on the frontend

Edit a module position on the frontend

Edit other things..

Compare the placement of the action buttons. (Save, Save and close, Cancel)

Here is the list that needs to be consistent, so choose either Top or bottom and change the others, and fix the icons

Edit Screen Location Of Buttons Currently Buttons Also
Article Bottom Save Save&Close Cancel
Module Top Save Cancel Versions
Profile Bottom Save Cancel No tick on save, no cross on cancel
Template Settings Top Save Cancel
Site Settings Top Save Cancel
Contact Bottom Save Cancel No cross on cancel

Expected result

Consistency. Either the action buttons (Save, Save and close, Cancel) are at the TOP of the page, or at the bottom.

Actual result

Some views (Editing a module) have the buttons at the top of the page

Some views (Editing content, Creating a contact) have the buttons at the bottom of the page.

avatar PhilETaylor PhilETaylor - open - 2 Feb 2021
avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 2 Feb 2021
avatar PhilETaylor PhilETaylor - change - 2 Feb 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 2 Feb 2021
avatar ciar4n ciar4n - change - 9 Mar 2021
Labels Added: ?
avatar ciar4n ciar4n - labeled - 9 Mar 2021
avatar richard67
richard67 - comment - 16 Mar 2021

@PhilETaylor Do you remember any other edit views beside the module edit which have the buttons at the top? Or in other words: Does PR #32703 seem complete to you?

avatar PhilETaylor
PhilETaylor - comment - 16 Mar 2021

#close

No idea sorry, I’ve slept since then :)

On 16 Mar 2021, at 15:41, Richard Fath @.***> wrote:

@PhilETaylor https://github.com/PhilETaylor Do you remember any other edit views beside the module edit which have the buttons at the top? Or in other words: Does PR #32703 #32703 seem complete to you?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #32250 (comment), or unsubscribe https://github.com/notifications/unsubscribe-auth/AADBVXFVUB6PP63RMRIEN43TD5337ANCNFSM4W7S6VTQ.

avatar richard67 richard67 - change - 16 Mar 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-03-16 18:58:02
Closed_By richard67
avatar richard67
richard67 - comment - 16 Mar 2021

Closing as having a pull request. Please test #32703 . Thanks in advance.

avatar richard67 richard67 - close - 16 Mar 2021
avatar richard67 richard67 - change - 18 Mar 2021
Status Closed New
Closed_Date 2021-03-16 18:58:02
Closed_By richard67
avatar richard67 richard67 - reopen - 18 Mar 2021
avatar richard67
richard67 - comment - 18 Mar 2021

Re-opening the issue since it turned out that the PR doesn't solve all inconsistencies.

avatar atharva20-coder
atharva20-coder - comment - 9 Apr 2021

can anyone attach an image of the issue, please?

avatar sandramay0905
sandramay0905 - comment - 10 Apr 2021

@atharva20-coder look at the mentioned pull request #32703.

avatar PhilETaylor
PhilETaylor - comment - 17 Apr 2021

Here is the list that needs to be consistent, so choose either Top or bottom and change the others, and fix the icons

Edit Screen Location Of Buttons Currently Buttons Also
Article Bottom Save Save&Close Cancel
Module Top Save Cancel Versions
Profile Bottom Save Cancel No tick on save, no cross on cancel
Template Settings Top Save Cancel
Site Settings Top Save Cancel
Contact Bottom Save Cancel No cross on cancel
avatar PhilETaylor PhilETaylor - change - 17 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 17 Apr 2021
avatar brianteeman
brianteeman - comment - 25 Apr 2021

#33294 and #33295 should complete this PR

avatar richard67 richard67 - change - 25 Apr 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-04-25 09:59:29
Closed_By richard67
avatar richard67 richard67 - close - 25 Apr 2021
avatar richard67
richard67 - comment - 25 Apr 2021

#33294 and #33295 should complete this PR

You mean this issue ;-)

Closing as having 2 pull requests. Please test #33294 and #33295 . Thanks in advance.

avatar PhilETaylor
PhilETaylor - comment - 25 Apr 2021

Thanks

Add a Comment

Login with GitHub to post a comment