? Success

User tests: Successful: Unsuccessful:

avatar MrBenGriffin
MrBenGriffin
3 Mar 2014

Remove expectation that hathor is always present.
Otherwise if hathor is removed, errors will appear on the Template Manager: Customise Template, and elsewhere.

avatar MrBenGriffin MrBenGriffin - open - 3 Mar 2014
avatar MrBenGriffin MrBenGriffin - change - 3 Mar 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-03-03 11:40:56
Labels Added: ? ?
avatar MrBenGriffin MrBenGriffin - close - 3 Mar 2014
avatar MrBenGriffin MrBenGriffin - close - 3 Mar 2014
avatar MrBenGriffin MrBenGriffin - change - 3 Mar 2014
Status Closed New
avatar MrBenGriffin MrBenGriffin - reopen - 3 Mar 2014
avatar MrBenGriffin MrBenGriffin - reopen - 3 Mar 2014
avatar wilsonge
wilsonge - comment - 3 Mar 2014

Whilst we're still split between JoomlaCode and GitHub would you be able to create a JC tracker item for this PR please? If not let me know and I'll do it for you :)

Thanks!

avatar MrBenGriffin
MrBenGriffin - comment - 3 Mar 2014

Hi George, I've added one at #33408.

On a separate issue, I noticed that Travis tests are failing my other pull request (JC 32989 / GH 3224) because the tests are wrong. What do I do about that?!

avatar wilsonge
wilsonge - comment - 3 Mar 2014

@test Code good. 1 more tester :)

avatar Hackwar
Hackwar - comment - 3 Mar 2014

what @wilsonge wrote. Code is good, can be merged.

avatar mbabker mbabker - reference | bb9adce - 10 Mar 14
avatar mbabker mbabker - merge - 10 Mar 2014
avatar mbabker mbabker - close - 10 Mar 2014
avatar mbabker mbabker - change - 10 Mar 2014
Status New Closed
Closed_Date 2014-03-03 11:40:56 2014-03-10 02:06:08
avatar mbabker mbabker - close - 10 Mar 2014
avatar MrBenGriffin MrBenGriffin - head_ref_deleted - 10 Mar 2014
avatar Bakual Bakual - reference | 5847bb1 - 12 May 14

Add a Comment

Login with GitHub to post a comment