[#32244] - [4.0] Hard coded spaces
- Fixed in Code Base
- 3 Feb 2021
- Medium
- Build: 4.0-dev
- # 32244
- Diff
- brianteeman:spaces
User tests: Successful: Unsuccessful:
It's 2021 and we really should be using css and not spaces for layout. This example PR is for the language layout and replaces the hard coded space with the correct css class of me-1. (because of the new BS5 classes this is RTL aware)
If accepted there are plenty of places to update
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
The only reason I can think of for why the space was misused for layout was that prior to bootstrap 5 it would have needed different classes for LTR and RTL
Then go for it
I will do when I get the opportunity. Doesnt hold back the merge of this PR
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32244.
Note while testing this in RTL:
I remarked the same problem as #32231 in many list where the width of some columns depends on the length of the title of the column. It is specially obvious when one uses Persian language.
Any volunteer to make general PR?
PS: Yes, I know it is unrelated to this PR.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32244.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32244.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-03 14:39:23 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
?
?
|
||
Thanks
thank you
@ciar4n can I get your steer on this please. I don’t have enough understanding of pros/cons to make an informed enough decision