Feeling Lucky
?
?
[#32234] - [4.0] Set sidebar countModule content aware
- Fixed in Code Base
- 3 Feb 2021
- Medium
- Build: 4.0-dev
- # 32234
- Diff
- ciar4n:patch-2
User tests: Successful: Unsuccessful:
Pull Request for Issue #32224 .
Summary of Changes
Makes sidebar-* countModules content-aware
Testing Instructions
- Enable only the Tag Similar module in either sidebar position
- Open an article with no similar tags
Before
Blank space in sidebar position
After
No blank space in sidebar position
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Title |
|
||||||
| Labels |
Added:
?
|
||
ciar4n
- comment
- 2 Feb 2021
Yes fair point. I've applied to all positions.
brianteeman
- comment
- 2 Feb 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32234.
chmst
- comment
- 2 Feb 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32234.
| Status | Pending | ⇒ | Ready to Commit |
chmst
- comment
- 2 Feb 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32234.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-03 07:28:50 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
?
|
||
drmenzelit
- comment
- 3 Feb 2021
Thanks
Wouldnt you need this in almost every instance of module count. Its just really obvious with the sidebar