Feeling Lucky
?
?
[#32216] - [4.0]Use form-select instead of form-control for states select
- Fixed in Code Base
- 1 Feb 2021
- Medium
- Build: 4.0-dev
- # 32216
- Diff
- joomdonation:patch-3
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Method state in Joomla\CMS\HTML\Helpers\Grid class generate states dropdown (select element), so it should use form-select class instead of form-control (bootstrap 5). I found this small issue while testing my extensions in latest Joomla 4 nightly build
Testing Instructions
Code review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
gostn
- comment
- 1 Feb 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32216.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 1 Feb 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32216.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-01 11:28:45 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
wilsonge
- comment
- 1 Feb 2021
Thanks!
I have tested this item✅ successfully on a2be4e0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32216.