[#32204] - [4.0] Protect bootstrap.loadComponent from being redefined
- Closed
- 30 Jan 2021
- Medium
- Build: 4.0-dev
- # 32204
- Diff
- Fedik:bs-protect-load-component
User tests: Successful: Unsuccessful:
Summary of Changes
This internal changes. To prevent bootstrap.loadComponent from being redefined.
The bootstrap components should be a list of predefined assets.
For now I suggest just make this method "private", so later one we can improve/trash it safely
Testing Instructions
Apply patch. All should work as before.
Actual result BEFORE applying this Pull Request
All works
Expected result AFTER applying this Pull Request
All works
Documentation Changes Required
none
bip bip @dgrammatiko @wilsonge
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
You can't override a single method anymore with the namespaced registry. You can only override the entire class. So not really sure if this solves much?
I wonder, why do you want to prevent this at all? If someone explicit want to change this method, why not allowing it?
You can only override the entire class. So not really sure if this solves much?
Well, I not very know how new HTML registry work, so just to be safe,
Someone still can extend the class.
If someone explicit want to change this method, why not allowing it?
This method need to be improved, and possible will be need to remove in future.
Example, the assets need to be predefined and loaded via $wa->useScript('bootstrap.blabla').
Currently I do not have a time for full changes.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-30 14:38:14 |
| Closed_By | ⇒ | Fedik | |
| Labels |
Added:
?
|
||
That was fast
I have tested this item✅ successfully on 5515b5e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32204.