[#32198] - [4.0] Fix WebComponent dependencies, and attributes rendering
- Fixed in Code Base
- 1 Feb 2021
- Medium
- Build: 4.0-dev
- # 32198
- Diff
- Fedik:wc-attributes-and-deps
User tests: Successful: Unsuccessful:
Summary of Changes
Fix WebComponent dependencies after merging #32171
And joomla-alert and joomla-tabs was duplicated in a "system" asset, however it is a "vendor" asset.
Also I have fixed "no value attributes" rendering, it should be good to test in 1 pr.
Testing Instructions
Apply patch, run npm install,
Open backend, and check for page source code where a scripts is rendered.
Look for example for joomla-alert-legacy.js
Actual result BEFORE applying this Pull Request
joomla-alert-legacy.js goes before webcomponents-sd-ce-pf.js
"nomodule" atribute rendered as nomodule=""
Expected result AFTER applying this Pull Request
joomla-alert-legacy.js goes after webcomponents-sd-ce-pf.js
"nomodule" attribute rendered as nomodule
Documentation Changes Required
none
bip bip @dgrammatiko @wilsonge
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32198.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32198.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-01 12:19:43 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
NPM Resource Changed
?
?
|
||
Thanks!
I have tested this item✅ successfully on 71b2674
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32198.