[#32196] - [4.0] Correcting WebAuthn display in login menu item
- Fixed in Code Base
- 1 Feb 2021
- Medium
- Build: 4.0-dev
- # 32196
- Diff
- infograf768:4.0_webauthn_login_menu
User tests: Successful: Unsuccessful:
Pull Request for Issue #32182
Summary of Changes
#31545 forgot to modify com_users login default_login tmpl and login modules
Testing Instructions
Set webautn to display when login.
Create a login menu item.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Note
This PR does not solve the tooltip display in the menu as well as in the login module
PLG_SYSTEM_WEBAUTHN_LOGIN_DESC="Login without a password using the W3C Web Authentication (WebAuthn) standard in compatible browsers. You need to have already set up WebAuthn authentication in your user profile."
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
| Title |
|
||||||
I have tested this item
I don't have a secret key but the form looks fine after applying the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32196.
@ceford Please withdraw your successful test because it's misleading. The PR as is fixes the form but breaks important functionality as I've written in my review of the PR in #32196
Please do not limit your source of information to the Joomla issue tracker site. It doesn't convey the entire picture (and really has no reason of existence, but that's another discussion for another day).
I have not tested this item.
I looked at the diff and it looked simple! But, untested as requested.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32196.
| Labels |
Added:
?
|
||
| Category | Front End com_users | ⇒ | Modules Administration Front End com_users Plugins |
@nikosdion @ceford
Modified PR as discussed above.
(tooltip is still not taken care of and should be the matter of another patch)
Please test again
It works as before for me - and I did read the discussion this time. However, being of a nervous disposition, I will wait for @nikosdion approval before pressing the pass button.
It works as before for me - and I did read the discussion this time. However, being of a nervous disposition, I will wait for @nikosdion approval before pressing the pass button.
@ceford No need to be nervous. If your test was successful, press the button. If it later turns out it was a mistake, that can happen. It happens to me, too sometimes. But that should not make us scared from further testing. I'm not sure if Nik will report back when all is ok now.
I have tested this item
Looked at the places changed in the diff - all seem OK.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32196.
@richard67 I always comment when I ask someone to fix something and they do. Just not on Sundays, man.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32196.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32196.
@richard67 I always comment when I ask someone to fix something and they do. Just not on Sundays, man.
@nikosdion Yes, and thanks for that. I haven't said you won't comment for sure, I just have said that it might not happen. I had the feeling @ceford was discouraged from marking his test result, and I wanted to encourage him again.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-01 07:54:11 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks!
@nikosdion
Does this break your former PR?