[#32194] - [4.0] Select checkbox [a11y]
- Fixed in Code Base
- 2 Feb 2021
- Medium
- Build: 4.0-dev
- # 32194
- Diff
- brianteeman:checkbox
User tests: Successful: Unsuccessful:
Just as every link on a page should be unique so should a field.
On all the list views we have a checkbox to select the item.
On some lists they have a label (hidden) similar to "Select itemtitle" which ensures that the label is unique
This PR adds this to all the remaining list views that just have the label value of "select"
There is no visual change as the label has the class "visually hidden" so the best way to check is to view the generated source of a list view eg articles and featured articles
before this PR only articles checkboxes have a unique value eg Select Homepage
after this pr the featured articles list items also have a unique value
(been waiting for the accessibility team to report this :( )
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_contenthistory com_fields com_installer com_languages com_menus com_messages com_modules com_newsfeeds com_plugins com_redirect com_tags com_users com_workflow |
User Actions Log and Content Security policy are the two (that I am aware of) that do not have a label. They should do but there is nothing sensible they can have
| Labels |
Added:
?
|
||
For the Select All checkbox, add a label Check All Items?
Separate issue
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32194.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32194.
Anything holding back this PR from being merged and in the beta 7?
Good luck @brianteeman.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-02 15:25:16 |
| Closed_By | ⇒ | drmenzelit |
Thanks
Thanks
I have tested this item✅ successfully on 20e4ba9
I went down the Admin menu and checked all of the items for which I have data. Select [item->name] present in all cases for which I have data, except User Actions Log, which is understandable. All good for me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32194.