? ?
avatar Quy
Quy
29 Jan 2021

Steps to reproduce the issue

Edit an article.
Click Publishing tab.
Click User icon.

Create a new menu item.
Select Single Article type.
Click Select button.

Actual result

select-user

select-article

avatar Quy Quy - open - 29 Jan 2021
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jan 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 29 Jan 2021
avatar brianteeman
brianteeman - comment - 29 Jan 2021

Its coming from the tbody-icon class

.tbody-icon {
padding: 0 3px;
text-align: center;
background-color: transparent;
border: 0;

avatar ciar4n ciar4n - change - 9 Mar 2021
Labels Added: ?
avatar ciar4n ciar4n - labeled - 9 Mar 2021
avatar NikitaEmberi
NikitaEmberi - comment - 16 Mar 2021

I would like to work on this issue. Can this issue be assigned to me? Thanks.

avatar drmenzelit
drmenzelit - comment - 16 Mar 2021

You don't need to ask for permission nor to be assigned to an issue. You can create a PR directly.

avatar NikitaEmberi
NikitaEmberi - comment - 16 Mar 2021

I am completely new to open source contribution. Thanks for informing.

avatar NikitaEmberi
NikitaEmberi - comment - 16 Mar 2021

Is this issue solved? Because the behaviour shown in image above does not appear in my forked repository.
It shows something like this:
image
image

avatar brianteeman
brianteeman - comment - 16 Mar 2021

@NikitaEmberi You are checking Joomla 3. This is a problem in Joomla 4

avatar NikitaEmberi
NikitaEmberi - comment - 16 Mar 2021

Oh my bad. I upgraded to joomla 4 but the behaviour shown in above image seems to be resolved
image

avatar Quy
Quy - comment - 17 Mar 2021

@NikitaEmberi The issue is that tbody-icon should not be in td but in a separate span instead. Please find all instances to fix.

\administrator\components\com_contact\tmpl\contacts\modal.php

Before:

						<td class="text-center tbody-icon">
							<span class="<?php echo $iconStates[$this->escape($item->published)]; ?>" aria-hidden="true"></span>
						</td>

After:

						<td class="text-center">
							<span class="tbody-icon">
								<span class="<?php echo $iconStates[$this->escape($item->published)]; ?>" aria-hidden="true"></span>
							</span>
						</td>
avatar NikitaEmberi
NikitaEmberi - comment - 20 Mar 2021

@Quy thanks for your help. It helped me solve the issue.

avatar Quy Quy - change - 20 Mar 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-03-20 14:05:54
Closed_By Quy
avatar Quy Quy - close - 20 Mar 2021
avatar Quy
Quy - comment - 20 Mar 2021

@NikitaEmberi There are more like this. Please do a find and fix. Thanks.

avatar NikitaEmberi
NikitaEmberi - comment - 20 Mar 2021

@Quy sir there were merge conflicts with the pr issued. Do I need to solve them? I see this issue is now closed...

avatar Quy
Quy - comment - 20 Mar 2021

@NikitaEmberi The procedure is to close the issue when there is a PR for it.

Add a Comment

Login with GitHub to post a comment