J4 Frontend Template No Code Attached Yet
avatar C-Lodder
C-Lodder
26 Jan 2021

Steps to reproduce the issue

Visit the frontend of your site

Actual result

Screenshot_2021-01-26 Testing Home

avatar C-Lodder C-Lodder - open - 26 Jan 2021
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2021
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 26 Jan 2021
avatar wilsonge
wilsonge - comment - 26 Jan 2021

This seems to be intentional. https://github.com/joomla/joomla-cms/blob/4.0-dev/templates/cassiopeia/scss/blocks/_layout.scss#L33 there's a 4rem top and bottom padding which means top-a and top-b there's 8rem padding.

@drmenzelit Comes from your commit here 6ad0537 - not sure if you want to adjust or if it's expected to you

avatar drmenzelit
drmenzelit - comment - 27 Jan 2021

We had a big discussion about white space between modules... we can replace padding with margin, then it will not sum up between containers

avatar C-Lodder
C-Lodder - comment - 27 Jan 2021

There shouldn't be any padding or margins. It's using css-grid, so it should be dealt with by grid-gap

avatar drmenzelit
drmenzelit - comment - 27 Jan 2021

I see... grid-gap for the body is set to 0 1em

avatar drmenzelit
drmenzelit - comment - 27 Jan 2021

but changing it will have other consequences... for example it will add a gap between header and banner
grafik

avatar ciar4n ciar4n - change - 9 Mar 2021
Labels Added: J4 Frontend Template
avatar ciar4n ciar4n - labeled - 9 Mar 2021
avatar brianteeman
brianteeman - comment - 25 Apr 2021

Any update on this?

avatar drmenzelit drmenzelit - change - 25 Apr 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-04-25 16:23:37
Closed_By drmenzelit
avatar drmenzelit drmenzelit - close - 25 Apr 2021
avatar drmenzelit
drmenzelit - comment - 25 Apr 2021

Closing with PR #33310

Add a Comment

Login with GitHub to post a comment