Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#3216] - [#33394] Move JHtml Bootstrap Accordion functions into JLayouts

? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
2 Mar 2014

How to reproduce the problem and/or test the patch::

Test that any uses of JHtml functions all work as expected. The best example to test is going to the the frontend contact option (if you have the sliders option activated). There should be no change before and after the patch

Note the unit tests still pass :)

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33394&start=0

avatar wilsonge wilsonge - open - 2 Mar 2014
avatar losedk
losedk - comment - 7 Apr 2014

Tested. Works as expected

avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 21 Aug 2014
Status New ⇒ Pending
avatar brianteeman brianteeman - change - 2 Sep 2014
Category ⇒ Layout
avatar brianteeman brianteeman - change - 19 Sep 2014
The description was changed
avatar zero-24 zero-24 - alter_testresult - 27 Nov 2014 - losedk: Tested successfully
avatar zero-24 zero-24 - change - 27 Nov 2014
Easy No ⇒ Yes
avatar anibalsanchez
anibalsanchez - comment - 14 Jan 2015

@test Ok

Contact form rendered Ok with the patch

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3216.
avatar anibalsanchez anibalsanchez - test_item - 14 Jan 2015 - Tested successfully
avatar zero-24 zero-24 - change - 14 Jan 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 14 Jan 2015

Moving to RTC thanks to all!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3216.
avatar wilsonge
wilsonge - comment - 14 Jan 2015

Hold merge until 3.5. I suspect we probably won't merge at all though as me and Roberto have had a chat and think that this kind of code is probably better in JLayouts. But yeah we'll wait and see

avatar zero-24
zero-24 - comment - 15 Jan 2015

@wilsonge hehe thanks for the update but I miss something can you update the copiright dates to 2015?

avatar brianteeman brianteeman - change - 16 Jan 2015
Labels Added: ?
avatar roland-d roland-d - change - 16 Jan 2015
Status Ready to Commit ⇒ Information Required
avatar roland-d
roland-d - comment - 16 Jan 2015

Moving to Information Required as @wilsonge pointed out it may move to JLayouts.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3216.
avatar brianteeman brianteeman - change - 31 Jan 2015
Milestone Added:
avatar brianteeman
brianteeman - comment - 31 Jan 2015

Set milestone to 3.5

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3216.
avatar phproberto phproberto - change - 13 Mar 2015
Milestone Added:
avatar zero-24 zero-24 - change - 13 May 2015
Milestone Removed:
Labels Removed: ?
avatar dgt41
dgt41 - comment - 3 Nov 2015

@wilsonge can you eliminate the conflicts here?

avatar wilsonge
wilsonge - comment - 3 Nov 2015

I'm closing this I think. I think the example we have with the tabs shows this method of using Jlayouts isn't optimal. And you can already override this in JHtml. In Joomla 4 I guess we will remove the JHtml method and just replace it with a Jlayout

avatar wilsonge wilsonge - change - 3 Nov 2015
Status Information Required ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-11-03 22:38:56
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 3 Nov 2015
avatar wilsonge wilsonge - close - 3 Nov 2015
avatar wilsonge wilsonge - head_ref_deleted - 3 Nov 2015
avatar zero-24 zero-24 - change - 4 Nov 2015
Milestone Removed:

Add a Comment

Login with GitHub to post a comment