Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#32153] - [4.0] Tinymce plugin options bootstrap 5

? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
25 Jan 2021

Pull Request for Issue #32152 .

Summary of Changes

Fixing the tabs in the tinyMCE builder

Testing Instructions

Check the issue above

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

857c671 25 Jan 2021 avatar dgrammatiko fix
avatar dgrammatiko dgrammatiko - open - 25 Jan 2021
avatar dgrammatiko dgrammatiko - change - 25 Jan 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jan 2021
Category ⇒ Layout
avatar brianteeman brianteeman - test_item - 25 Jan 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 25 Jan 2021

I have tested this item ✅ successfully on 857c671

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32153.

avatar gostn gostn - test_item - 25 Jan 2021 - Tested successfully
avatar gostn
gostn - comment - 25 Jan 2021

I have tested this item ✅ successfully on 857c671

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32153.

avatar infograf768
infograf768 - comment - 25 Jan 2021

Tabs now working but we still have a console error here:

Uncaught TypeError: tabLink is null
    showTab http://localhost:8888/newfolder/joomla40/media/vendor/joomla-custom-elements/js/joomla-tab.js:287
    connectedCallback http://localhost:8888/newfolder/joomla40/media/vendor/joomla-custom-elements/js/joomla-tab.js:165
    <anonymous> http://localhost:8888/newfolder/joomla40/media/vendor/joomla-custom-elements/js/joomla-tab.js:2
    <anonymous> http://localhost:8888/newfolder/joomla40/media/vendor/joomla-custom-elements/js/joomla-tab.js:404
joomla-tab.js:287:7
avatar dgrammatiko
dgrammatiko - comment - 25 Jan 2021

Clean your local storage and make sure the url doesn't have a #something

This is related to joomla's tabs not bs

avatar infograf768 infograf768 - test_item - 25 Jan 2021 - Tested successfully
avatar infograf768
infograf768 - comment - 25 Jan 2021

I have tested this item ✅ successfully on 857c671

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32153.

avatar infograf768 infograf768 - change - 25 Jan 2021
Status Pending ⇒ Ready to Commit
avatar infograf768
infograf768 - comment - 25 Jan 2021

rtc. thanks

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32153.

avatar infograf768 infograf768 - change - 25 Jan 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-01-25 11:50:43
Closed_By ⇒ infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 25 Jan 2021
avatar infograf768 infograf768 - merge - 25 Jan 2021
avatar infograf768
infograf768 - comment - 25 Jan 2021

indeed, was remaining a # ;)

Add a Comment

Login with GitHub to post a comment