[#32126] - [4.0] Modify layout for tags using BS5
- Fixed in Code Base
- 24 Jan 2021
- Medium
- Build: 4.0-dev
- # 32126
- Diff
- drmenzelit:4.0-dev-tags
User tests: Successful: Unsuccessful:
Summary of Changes (modified)
Changed class badge for tags and use now btn classes as explained in the BS5 documentation:
https://getbootstrap.com/docs/5.0/components/buttons/#button-tags
Tweak some css for tags on articles and on popular tags module
Thanks to @chmst for the help ;-)
Testing Instructions
Install blog example data. Run npm
Actual result BEFORE applying this Pull Request
Tags are too close to each other, they are underlined, on hover the colour of the text is too dark...
Expected result AFTER applying this Pull Request
Tags look good
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Front End Templates (site) NPM Change |
a) Sorry, I made mistake, now it's OK:
b) Popular Tags: Set Bootstrap to Size 5 (field) and tried under Module Class: btn btn-info. But maybe wrong action from me?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32126.
For popular tags you don't need to set classes. The tags are showed as links with a badge for the number. That is ok. My changes only added some padding to the links.
@drmenzelit ah, I see :-) As I wrote above, I tried to set some classes.
Because as stated in Summary of changes: Remove class badge for tags. Module Popular tags shows still:
<span class="tag-count badge bg-info">4</span>
So, it seems everything is OK now?
@ChristineWk I think my explanation of the PR was not clear, I changed now the summary of changes. You don't need to add or remove classes to test the PR. That is what this PR does.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32126.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32126.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32126.
| Labels |
Added:
?
?
NPM Resource Changed
?
|
||
chmst
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-24 13:52:48 |
| Closed_By | ⇒ | chmst | |
| Labels | |||
Tried something :-)
Result after using class: btn btn-info with enabled Package: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/32126/downloads/39509/pr_list.xml
but missing space after JoomlaV4 and New Feature Workflow
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32126.