[#32120] - [4.0] External link icon placement
- Fixed in Code Base
- 23 Jan 2021
- Medium
- Build: 4.0-dev
- # 32120
- Diff
- brianteeman:external_link
User tests: Successful: Unsuccessful:
As identified by @infograf768 the placement of the icon to indicate an external link is incorrect in RTL.
Unlike his proposal which creates additional css just for the RTL to wap the class from ::before to ::after this PR does it the correct way.
The icon is still ::before the beginning of the text and now correctly identifies the direction.
No need for a separate class in the css at all. ;)
PR #32101 should be reverted and this used instead as its the correct semantic way
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
we still have a padding problem as it still uses padding-right instead of left
That would be resolved when the build tools are updated to use rtlcss
Let's not as your pr is wrong and merging the two would end up with two icons. The use of inline-block is correct. That's why the menu icons work without an rtl override
| Labels |
Added:
NPM Resource Changed
?
|
||
Padding resolved by using padding-inline-end which is therefore the same for LTR and RTL
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-23 20:05:50 |
| Closed_By | ⇒ | wilsonge |
Thanks!
testing