NPM Resource Changed PR-4.0-dev

Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Jan 2021

As identified by @infograf768 the placement of the icon to indicate an external link is incorrect in RTL.

Unlike his proposal which creates additional css just for the RTL to wap the class from ::before to ::after this PR does it the correct way.

The icon is still ::before the beginning of the text and now correctly identifies the direction.

No need for a separate class in the css at all. ;)

PR #32101 should be reverted and this used instead as its the correct semantic way

avatar brianteeman brianteeman - open - 23 Jan 2021
avatar brianteeman brianteeman - change - 23 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jan 2021
Category Administration Templates (admin) NPM Change
avatar infograf768
infograf768 - comment - 23 Jan 2021

testing

avatar infograf768
infograf768 - comment - 23 Jan 2021

we still have a padding problem as it still uses padding-right instead of left

avatar infograf768
infograf768 - comment - 23 Jan 2021

Screen Shot 2021-01-23 at 11 55 43

avatar brianteeman
brianteeman - comment - 23 Jan 2021

That would be resolved when the build tools are updated to use rtlcss

avatar infograf768
infograf768 - comment - 23 Jan 2021

That would be resolved when the build tools are updated to use rtlcss

Then let's wait to revert #32101 and merge this.

avatar brianteeman
brianteeman - comment - 23 Jan 2021

Let's not as your pr is wrong and merging the two would end up with two icons. The use of inline-block is correct. That's why the menu icons work without an rtl override

avatar brianteeman brianteeman - change - 23 Jan 2021
Labels Added: NPM Resource Changed PR-4.0-dev
avatar brianteeman
brianteeman - comment - 23 Jan 2021

Padding resolved by using padding-inline-end which is therefore the same for LTR and RTL

avatar wilsonge wilsonge - change - 23 Jan 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-23 20:05:50
Closed_By wilsonge
avatar wilsonge wilsonge - close - 23 Jan 2021
avatar wilsonge wilsonge - merge - 23 Jan 2021
avatar wilsonge
wilsonge - comment - 23 Jan 2021

Thanks!

Add a Comment

Login with GitHub to post a comment