? ? Success

User tests: Successful: Unsuccessful:

avatar radiant-tech
radiant-tech
28 Feb 2014

All Tags view expected image params to be stored as a separate JRegistry object -- instead these are lumped into params. default_items.php also had problems with incorrect and missing param names.

Added 'float_intro' field to config to prevent the div around the image from having class="pull- item-image" (a value is expected as the tag param includes a JGLOBAL option). Default value is none, and if set to none, 'pull-' is not included in the class.

This does add a new language string.

How do we handle the sql for adding the new config field?
Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32881

avatar radiant-tech radiant-tech - open - 28 Feb 2014
avatar zero-24
zero-24 - comment - 28 Feb 2014

Here is the Tracker for this:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32881
You may blame the J!Tracker Application for transmitting this comment.

@radiant-tech
Sorry have not see your link here. It looks that it was lost here:
http://issues.joomla.org/tracker/joomla-cms/3208

avatar losedk
losedk - comment - 7 Apr 2014

Tested the pull request. Works as expected.

avatar Bakual
Bakual - comment - 14 Jul 2014

@radiant-tech The current code in com_tags is less than optimal because it converts the params object to an array. If it would be left as a JRegistry object, this PR would be so much simpler. But now we're stuck with it...
However creating a new property images which contains the original item params is a bad idea as well. If anything, create a new property params2 (or similar) and store the already merged params before they're converted to an array.
Then you could use all the joys of JRegistry and it already takes care of the menu and component parameters and you can specifiy a default value.
Otherwise just use the parameters as stored in the $item->params array. There you already have the new global value if applicable.

How do we handle the sql for adding the new config field?

You don't have to do anything in the SQL. But you need to define a default value within the code. It will act as fallback as long as the global value isn't set.

avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar brianteeman brianteeman - change - 2 Sep 2014
Category Tags
avatar roland-d
roland-d - comment - 20 Aug 2015

Hello @radiant-tech

Thank you for your contribution.

The last comment here was on 14th July 2014. So the question is, Is this issue/pull request still valid? Can you also have a look at the comment by @Bakual ?
If no reply is received within 4 weeks we will close this issue.

Thanks for understanding!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3208.

avatar roland-d roland-d - change - 20 Aug 2015
Status Pending Information Required
avatar roland-d
roland-d - comment - 7 Nov 2015

@radiant-tech Since no reply has been received in the last 4 weeks I am going to close the issue. If you want to continue working on it at a later date, feel free to re-open the issue. Thank you for your contribution.

avatar roland-d roland-d - change - 7 Nov 2015
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2015-11-07 09:06:45
Closed_By roland-d
avatar roland-d roland-d - close - 7 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - change - 7 Nov 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment