? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
17 Jan 2021

Summary of Changes

When using the xtd menu pop-up in frontend, the searchtools layout is fetched from the default core searchtools layout instead of the custom com_menus one. The result is that the filters are always visible whrn the pop-up displays.

This patch adds the custom admin com_menus searchtools layout to frontend.

Testing Instructions

Edit an article in frontend.
Click CMS Content = > Menu

Actual result BEFORE applying this Pull Request

xtd_menu_before

Expected result AFTER applying this Pull Request

xtd_menu_after

Documentation Changes Required

avatar infograf768 infograf768 - open - 17 Jan 2021
avatar infograf768 infograf768 - change - 17 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2021
Category Front End
avatar toivo toivo - test_item - 17 Jan 2021 - Tested successfully
avatar toivo
toivo - comment - 17 Jan 2021

I have tested this item successfully on 98434ec

Tested successfully in Beta7-dev of 17 January using PHP 8.0.1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32066.

avatar richard67
richard67 - comment - 17 Jan 2021

@infograf768 Couldn't the code related to the selector field (client_id) be simplified or removed here for the frontend?

avatar infograf768
infograf768 - comment - 17 Jan 2021

@richard67
I suppose we could, but let's say we have to modify for any reason the admin layout, it would be much simpler to copy/paste the similar changes to the frontend one.

avatar gostn gostn - test_item - 17 Jan 2021 - Tested successfully
avatar gostn
gostn - comment - 17 Jan 2021

I have tested this item successfully on 98434ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32066.

avatar richard67 richard67 - test_item - 17 Jan 2021 - Tested successfully
avatar richard67
richard67 - comment - 17 Jan 2021

I have tested this item successfully on 98434ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32066.

avatar richard67 richard67 - change - 17 Jan 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 17 Jan 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32066.

avatar richard67 richard67 - change - 17 Jan 2021
Labels Added: ? ?
avatar chmst chmst - change - 17 Jan 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-17 17:20:50
Closed_By chmst
Labels
avatar chmst chmst - close - 17 Jan 2021
avatar chmst chmst - merge - 17 Jan 2021
avatar chmst
chmst - comment - 17 Jan 2021

Thanks!

Add a Comment

Login with GitHub to post a comment