Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#32060] - [4.0] Form label [a11y]

? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Jan 2021

Each <form> element and form role that needs to be exposed as a landmark must be given an accessible name. This name will allow an assistive technology user to be able to quickly understand the purpose of the form landmark.

You can easily test this with the skipto plugin. Before this PR the item is just Form After this PR the item is either Form: New xxxx or Form: Edit xxx

  • com_banners
  • com_categories
  • com_contact
  • com_content
  • com_fields
  • com_finder
  • com_installer
  • com_languages
  • com_mails
  • com_menus
  • com_messages
  • com_modules
  • com_newsfeeds
  • com_plugins
  • com_privacy
  • com_redirect
  • com_tags
  • com_templates
  • com_users
  • com_workflow
avatar brianteeman brianteeman - open - 16 Jan 2021
avatar brianteeman brianteeman - change - 16 Jan 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2021
Category ⇒ Administration com_categories com_contact com_content Language & Strings
avatar brianteeman brianteeman - change - 16 Jan 2021
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2021
Category Administration com_categories com_contact com_content Language & Strings ⇒ Administration com_categories com_contact com_content com_modules com_newsfeeds Language & Strings
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2021
Category Administration com_categories com_contact com_content Language & Strings com_modules com_newsfeeds ⇒ Administration com_categories com_contact com_content com_finder com_modules com_newsfeeds com_tags Language & Strings
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2021
Category Administration com_categories com_contact com_content Language & Strings com_modules com_newsfeeds com_finder com_tags ⇒ Administration com_categories com_contact com_content com_fields com_finder com_modules com_newsfeeds com_tags Language & Strings
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2021
Category Administration com_categories com_contact com_content Language & Strings com_modules com_newsfeeds com_finder com_tags com_fields ⇒ Administration com_categories com_contact com_content com_fields com_finder com_menus com_modules com_newsfeeds com_tags com_users Language & Strings
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2021
Category Administration com_categories com_contact com_content Language & Strings com_modules com_newsfeeds com_finder com_tags com_fields com_menus com_users ⇒ Administration com_banners com_categories com_contact com_content com_fields com_finder com_installer com_languages com_menus com_messages com_modules com_newsfeeds com_plugins com_redirect com_tags com_templates com_users com_workflow
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar brianteeman brianteeman - change - 16 Jan 2021
The description was changed
avatar brianteeman brianteeman - edited - 16 Jan 2021
avatar brianteeman brianteeman - change - 16 Jan 2021
Labels Removed: ?
a35c098 16 Jan 2021 avatar brianteeman space
avatar carcam
carcam - comment - 21 Jan 2021

Weird enough the patch does not update the language file so the aria-label shows just the key string...

avatar brianteeman
brianteeman - comment - 21 Jan 2021

Thats probably patchtester bug - i think it has issues when you have a lot of files.

avatar carcam
carcam - comment - 22 Jan 2021

It looks like it. Changes in code reflect the language string so I will test it again and will take that into consideration.

avatar wilsonge wilsonge - change - 24 Jan 2021
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-01-24 17:49:56
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 24 Jan 2021
avatar wilsonge wilsonge - merge - 24 Jan 2021
avatar wilsonge
wilsonge - comment - 24 Jan 2021

Merging on review - as if patchtester fails we're unlikely to get many tests and this is a pretty simple patch

avatar brianteeman
brianteeman - comment - 24 Jan 2021

thanks

Add a Comment

Login with GitHub to post a comment